Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore user defined Pk for resumable full refresh #38054

Merged
merged 2 commits into from
May 8, 2024
Merged

ignore user defined Pk for resumable full refresh #38054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5472a3f
ignore user defined Pk for resumable full refresh
rodireich May 8, 2024
6d0dc8c
ignore user defined Pk for resumable full refresh
rodireich May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-mssql/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ data:
connectorSubtype: database
connectorType: source
definitionId: b5ea17b1-f170-46dc-bc31-cc744ca984c1
dockerImageTag: 4.0.20
dockerImageTag: 4.0.21
dockerRepository: airbyte/source-mssql
documentationUrl: https://docs.airbyte.com/integrations/sources/mssql
githubIssueLabel: source-mssql
Expand Down
3 changes: 0 additions & 3 deletions ...nnectors/source-mssql/src/main/java/io/airbyte/integrations/source/mssql/MssqlSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,9 +668,6 @@ public boolean supportResumableFullRefresh(final JdbcDatabase database, final Co
&& !airbyteStream.getStream().getSourceDefinedPrimaryKey().isEmpty()) {
return true;
}
if (airbyteStream.getPrimaryKey() != null && !airbyteStream.getPrimaryKey().isEmpty()) {
return true;
}

return false;
}
Expand Down
3 changes: 2 additions & 1 deletion docs/integrations/sources/mssql.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,8 @@ WHERE actor_definition_id ='b5ea17b1-f170-46dc-bc31-cc744ca984c1' AND (configura

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:------------------------------------------------------------------------------------------------------------------|:------------------------------------------------------------------------------------------------------------------------------------------------|
| 4.0.20 | 2024-05-07 | [38042](https://github.com/airbytehq/airbyte/pull/38042) | Bump debezium version to latest. |
| 4.0.21 | 2024-05-07 | [38054](https://github.com/airbytehq/airbyte/pull/38054) | Resumeable refresh should run only if there is source defined pk. |
| 4.0.20 | 2024-05-07 | [38042](https://github.com/airbytehq/airbyte/pull/38042) | Bump debezium version to latest. |
| 4.0.19 | 2024-05-07 | [38029](https://github.com/airbytehq/airbyte/pull/38029) | Fix previous release. |
| 4.0.18 | 2024-04-30 | [37451](https://github.com/airbytehq/airbyte/pull/37451) | Resumable full refresh read of tables. |
| 4.0.17 | 2024-05-02 | [37781](https://github.com/airbytehq/airbyte/pull/37781) | Adopt latest CDK. |
Expand Down
Loading