revert contention-reducing change in destination-snowflake #38052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
stephane-airbyte
changed the title
stephane-airbyte
force-pushed
the
stephane/05-07-revert_contention-reducing_change_in_snwoflake-destination
branch
from
9e461a6
to
7350506
Compare
octavia-squidington-iii
added
the
area/documentation
stephane-airbyte
force-pushed
the
stephane/05-07-revert_contention-reducing_change_in_snwoflake-destination
branch
from
7350506
to
fba9806
Compare
edgao
approved these changes
May 7, 2024
stephane-airbyte
force-pushed
the
stephane/05-07-revert_contention-reducing_change_in_snwoflake-destination
branch
from
fba9806
to
bfb3f64
Compare
|
Nonblocking: I wonder if we can revert b69eae7 after this pr 🤔 |
evantahler
approved these changes
May 8, 2024
stephane-airbyte
force-pushed
the
stephane/05-07-revert_contention-reducing_change_in_snwoflake-destination
branch
from
bfb3f64
to
a226aeb
Compare
stephane-airbyte
force-pushed
the
stephane/05-07-revert_contention-reducing_change_in_snwoflake-destination
branch
2 times, most recently
from
16ab3e9
to
29b1bcb
Compare
stephane-airbyte
force-pushed
the
stephane/05-07-revert_contention-reducing_change_in_snwoflake-destination
branch
from
29b1bcb
to
cc9aa23
Compare
stephane-airbyte
force-pushed
the
stephane/05-07-revert_contention-reducing_change_in_snwoflake-destination
branch
from
cc9aa23
to
40a1f1a
Compare
stephane-airbyte
deleted the
stephane/05-07-revert_contention-reducing_change_in_snwoflake-destination
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as part of the move of destination-snowflake to the kotlin CDK, we tried improve concurrency by only
DELETEing from_airbyte_destination_stateif it has some data to delete (by issuing anIF EXISTSin the same transaction.Looks like it might be causing some stuck syncs, so we're reverting that "improvement"