Destinations CDK: Async framework tracks stream success #37721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
edgao
force-pushed
the
edgao/async_framework_tracks_stream_success
branch
from
ee5344b
to
e634730
Compare
octavia-squidington-iii
added
connectors/destination/bigquery
area/connectors
edgao
force-pushed
the
edgao/async_framework_tracks_stream_success
branch
from
e634730
to
e1f643f
Compare
edgao
force-pushed
the
edgao/bq_incremental_td
branch
from
8f95f23
to
5cdcc77
Compare
edgao
force-pushed
the
edgao/async_framework_tracks_stream_success
branch
from
e1f643f
to
107b651
Compare
edgao
commented
May 7, 2024
| @@ -20,6 +22,7 @@ class BufferEnqueue( | |||
| private val memoryManager: GlobalMemoryManager, | |||
| private val buffers: ConcurrentMap<StreamDescriptor, StreamAwareQueue>, | |||
| private val stateManager: GlobalAsyncStateManager, | |||
| private val streamsWithSuccessStatus: ConcurrentHashSet<StreamDescriptor>, | |||
There was a problem hiding this comment.
this should probably be a map streamdescriptor -> status, so that we can explicitly check whether each stream succeeded or failed (and error if a stream had neither status)
edgao
force-pushed
the
edgao/bq_incremental_td
branch
from
5cdcc77
to
35637b5
Compare
edgao
force-pushed
the
edgao/async_framework_tracks_stream_success
branch
from
107b651
to
f636711
Compare
edgao
force-pushed
the
edgao/bq_incremental_td
branch
from
a8278f6
to
98ec352
Compare
edgao
force-pushed
the
edgao/async_framework_tracks_stream_success
branch
from
f636711
to
ec98930
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?