Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marcos/test pr 36349 #37696

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+58 −29
Open

Marcos/test pr 36349 #37696

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fe04633
Firebolt Source: Upgrade for new Firebolt version
ptiurin Mar 21, 2024
25669e1
fix unit tests
ptiurin Mar 22, 2024
7bfb32c
engine is required propetry
ptiurin Mar 22, 2024
857fe69
Avoid breaking existing connections
ptiurin Apr 2, 2024
300d275
Merge branch 'master' into firebolt-source-major-upgrade
ptiurin Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix unit tests
  • Loading branch information
@ptiurin
ptiurin committed Mar 22, 2024
commit 25669e115e43e364a75b8891eb7ac99b5ebf38df
12 changes: 6 additions & 6 deletions airbyte-integrations/connectors/source-firebolt/unit_tests/test_firebolt_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
def config(request):
args = {
"database": "my_database",
"username": "my_username",
"password": "my_password",
"client_id": "my_id",
"client_secret": "my_secret",
"engine": request.param,
}
return args
Expand All @@ -38,8 +38,8 @@ def config(request):
def config_no_engine():
args = {
"database": "my_database",
"username": "my_username",
"password": "my_password",
"client_id": "my_id",
"client_secret": "my_secret",
}
return args

Expand Down Expand Up @@ -93,8 +93,8 @@ def test_parse_config(config, logger):
result = parse_config(config, logger)
assert result["database"] == "my_database"
assert result["engine_name"] == "override_engine"
assert result["auth"].username == "my_username"
assert result["auth"].password == "my_password"
assert result["auth"].client_id == "my_id"
assert result["auth"].client_secret == "my_secret"
config["engine"] = "override_engine.api.firebolt.io"
result = parse_config(config, logger)
assert result["engine_url"] == "override_engine.api.firebolt.io"
Expand Down