Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added azure storage into CI yml #3762

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Added azure storage into CI yml #3762

merged 1 commit into from
Jun 1, 2021

Conversation

Phlair
Copy link
Contributor

@Phlair Phlair commented May 31, 2021

What

In order for integration tests requiring secrets to run in master repo, the yml workflows need the commands to add the new secret(s) from github secrets to env vars. This PR therefore is required as a precursor to #3660 so that integration tests can run successfully.

How

By adding reference to secrets as outlined here: #3733

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

Recommended reading order

  1. test.java
  2. component.ts
  3. the rest

@Phlair Phlair requested review from sherifnada and davinchia May 31, 2021 13:56
@auto-assign auto-assign bot requested review from cgardens and michel-tricot May 31, 2021 13:56
@Phlair
Copy link
Contributor Author

Phlair commented May 31, 2021

@davinchia I think this is needed because even when running integration test with "repo=Phlair/airbyte", the yml workflow is still the master yml right? Perhaps we could abstract these setting of env vars from these files in a way that makes this extra PR unnecessary?

@davinchia
Copy link
Contributor

Yeap! There is one more bit in addition to this. I'll merge this in, add that in and go back to your original PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants