✨Source BambooHR - Migrate Python CDK to Low-code CDK #37452
Conversation
…grate_bamboohr_lowcode
…grate_bamboohr_lowcode
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
There was a problem hiding this comment.
Please use Connector Builder for migrations, it's a hard requirement. /cc @lazebnyi. For community connectors that can be built in Builder with custom components locally, it should be a requirement.
Now that we also moved live-testing to open source, we should also require a full live test passing report. /cc @alafanechere.
Did you actually read the readme and try doing acceptance tests or building with Gradle? Last I checked, those won't work and are outdated.
airbyte-integrations/connectors/source-bamboo-hr/pyproject.toml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-bamboo-hr/pyproject.toml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-bamboo-hr/source_bamboo_hr/manifest.yaml
Outdated
Show resolved
Hide resolved
…pe/migrate_bamboohr_lowcode
Co-authored-by: Natik Gadzhi <natik@respawn.io>
…pe/migrate_bamboohr_lowcode
…pe/migrate_bamboohr_lowcode
…pe/migrate_bamboohr_lowcode
…pe/migrate_bamboohr_lowcode
|
@natikgadzhi All tests passed can you review please? |
…pe/migrate_bamboohr_lowcode
There was a problem hiding this comment.
lgtm
regression tests - https://github.com/airbytehq/airbyte/actions/runs/9199446269
…airbyte into tope/migrate_bamboohr_lowcode
|
|
||
| [tool.poetry.dependencies] | ||
| python = "^3.9,<3.12" | ||
| airbyte-cdk = "0.80.0" | ||
| PyBambooHR = "==0.8.1" | ||
| airbyte-cdk = "^1" |
| pytest = "^6.1" | ||
| requests-mock = "*" | ||
| pytest-mock = "*" | ||
| pytest = "*" |
|
|
||
|
|
||
| @dataclass | ||
| class BambooHRSchemaLoader(JsonFileSchemaLoader): |
There was a problem hiding this comment.
This would benefit from a comment explaining why Bamboo needs a custom schema loader.
| @@ -0,0 +1,156 @@ | |||
| version: 0.83.0 | |||
There was a problem hiding this comment.
You could bump this to 1.0+ as well, so version in the poetry.lock matchies this.
|
Since we've ran regression tests, I am happy to merge this as is to wrap it up, the new thing is clearly better than the old one. |
What
Migrate BambooHR Python CDK to Low-code CDK fixes airbytehq/airbyte-internal-issues#6758
How
Developed using UI Builder and the Low-code CDK
Recommended reading order
manifest.yamlcomponents.py🚨 User Impact 🚨
No
Pre-merge Actions
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.