Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-prestashop: ensure inline schemas, updated cdk, poetry (where possible) #37233

Merged

Conversation

bleonard
Copy link
Contributor

@bleonard bleonard commented Apr 13, 2024

This was created from a set of automated scripts. In each case, not every update was needed for every connector, but overall here is what happened:

  • auto-schema update -s all description: added descriptions to json and inline schemas
  • connector-code migrate_to_yaml -c all --type source: migrates json schemas to connectors with a manifest
  • airbyte-ci connectors --name=<all modified connectors from above> migrate_to_base_image: makes sure that each is using a base docker image and updates docs
  • airbyte-ci connectors --name=<all modified connectors from above> migrate-to-poetry: moves connectors not already using poetry to do so and updates documentation
  • airbyte-ci connectors --name=<all modified connectors from above> up_to_date: updated the CDK to newer (0.80.0) version

The version number and changelogs were also bumped using the connector-code pulls command.

Copy link

vercel bot commented Apr 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 20, 2024 9:16pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/prestashop labels Apr 13, 2024
@bleonard bleonard changed the title source-prestashop: schema descriptions source-prestashop: ensure inline schemas, updated cdk, poetry (where possible) Apr 20, 2024
@natikgadzhi
Copy link
Contributor

Discover fails with empty catalog, but we don't have cloud connections that I know of — I want to get this in so I can also layer #34513 on top of it. I stumbled at this when I looked at metadata_lib for another formatting issue 🙃 and found #38014 this.

@natikgadzhi natikgadzhi merged commit 70d35d1 into master May 7, 2024
31 of 33 checks passed
@natikgadzhi natikgadzhi deleted the autopull/schema-descriptions-d2a8da/source-prestashop branch May 7, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation autopull connectors/source/prestashop test_catalog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants