Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add entry into JAVA_OPTS to always select log4j2.xml as our logger configuration #35569

Merged
merged 1 commit into from
Feb 23, 2024
Merged

add entry into JAVA_OPTS to always select log4j2.xml as our logger configuration #35569

merged 1 commit into from
Feb 23, 2024

Conversation

stephane-airbyte
Copy link
Contributor

No description provided.

@stephane-airbyte stephane-airbyte requested a review from a team as a code owner February 23, 2024 02:08
@vercel Vercel
Copy link

vercel bot commented Feb 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 23, 2024 2:09am

@stephane-airbyte Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

postamar
postamar reviewed Feb 23, 2024
View reviewed changes
Copy link
Contributor

@postamar postamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check that this doesn't screw up the logging during integration tests before merging please.

postamar
postamar approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@postamar postamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and this seems to work. When building a connector image using the assemble gradle task, the log messages printed when we call SPEC as a sanity check are json with this PR and textual on master.

This was referenced Feb 23, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@postamar postamar merged commit 9144011 into master Feb 23, 2024
31 checks passed
@postamar postamar deleted the stephane/02-22-add_entry_into_JAVA_OPTS_to_always_select_log4j2.xml_as_our_logger_configuration branch February 23, 2024 03:37
postamar pushed a commit that referenced this pull request Feb 23, 2024
@stephane-airbyte
destination-s3: bump patch version following #35569 (#35576)
f44ea6a 
Co-authored-by: Stephane Geneix <stephane@airbyte.io>
postamar pushed a commit that referenced this pull request Feb 23, 2024
@stephane-airbyte
destination-snowflake: bump patch version following #35569 (#35575)
e10bbbf 
Co-authored-by: Stephane Geneix <stephane@airbyte.io>
postamar pushed a commit that referenced this pull request Feb 23, 2024
@stephane-airbyte
destination-bigquery: bump patch version following #35569 (#35574)
084671b 
Co-authored-by: Stephane Geneix <stephane@airbyte.io>
postamar pushed a commit that referenced this pull request Feb 23, 2024
@stephane-airbyte
source-mysql: bump patch version following #35569 (#35573)
2b370f8 
Co-authored-by: Stephane Geneix <stephane@airbyte.io>
postamar pushed a commit that referenced this pull request Feb 23, 2024
@stephane-airbyte
source-postgres: bump patch version following #35569 (#35572)
407cba8 
Co-authored-by: Stephane Geneix <stephane@airbyte.io>
postamar pushed a commit that referenced this pull request Feb 23, 2024
@stephane-airbyte
source-mongodb-v2: bump patch version following #35569 (#35571)
aa084a9 
Co-authored-by: Stephane Geneix <stephane@airbyte.io>
@stephane-airbyte stephane-airbyte mentioned this pull request Feb 23, 2024
Merged
tanawatpan pushed a commit to tanawatpan/airbyte that referenced this pull request Feb 24, 2024
@stephane-airbyte @tanawatpan
add entry into JAVA_OPTS to always select log4j2.xml as our logger co…
1bf4e65 
…nfiguration (airbytehq#35569)
tanawatpan pushed a commit to tanawatpan/airbyte that referenced this pull request Feb 24, 2024
@stephane-airbyte @tanawatpan
destination-s3: bump patch version following airbytehq#35569 (airbyte…
e6fb9d4 
…hq#35576)

Co-authored-by: Stephane Geneix <stephane@airbyte.io>
tanawatpan pushed a commit to tanawatpan/airbyte that referenced this pull request Feb 24, 2024
@stephane-airbyte @tanawatpan
destination-snowflake: bump patch version following airbytehq#35569 (a…
a77fdf4 
…irbytehq#35575)

Co-authored-by: Stephane Geneix <stephane@airbyte.io>
tanawatpan pushed a commit to tanawatpan/airbyte that referenced this pull request Feb 24, 2024
@stephane-airbyte @tanawatpan
destination-bigquery: bump patch version following airbytehq#35569 (a…
3a0d56d 
…irbytehq#35574)

Co-authored-by: Stephane Geneix <stephane@airbyte.io>
tanawatpan pushed a commit to tanawatpan/airbyte that referenced this pull request Feb 24, 2024
@stephane-airbyte @tanawatpan
source-mysql: bump patch version following airbytehq#35569 (airbytehq…
7e9fec2 
…#35573)

Co-authored-by: Stephane Geneix <stephane@airbyte.io>
tanawatpan pushed a commit to tanawatpan/airbyte that referenced this pull request Feb 24, 2024
@stephane-airbyte @tanawatpan
source-postgres: bump patch version following airbytehq#35569 (airbyt…
3b6bde0 
…ehq#35572)

Co-authored-by: Stephane Geneix <stephane@airbyte.io>
tanawatpan pushed a commit to tanawatpan/airbyte that referenced this pull request Feb 24, 2024
@stephane-airbyte @tanawatpan
source-mongodb-v2: bump patch version following airbytehq#35569 (airb…
b815785 
…ytehq#35571)

Co-authored-by: Stephane Geneix <stephane@airbyte.io>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@stephane-airbyte @jatinyadav-cc
source-postgres: bump patch version following airbytehq#35569 (airbyt…
9acdf11 
…ehq#35572)

Co-authored-by: Stephane Geneix <stephane@airbyte.io>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@stephane-airbyte @jatinyadav-cc
source-mongodb-v2: bump patch version following airbytehq#35569 (airb…
17da93f 
…ytehq#35571)

Co-authored-by: Stephane Geneix <stephane@airbyte.io>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@stephane-airbyte @jatinyadav-cc
add entry into JAVA_OPTS to always select log4j2.xml as our logger co…
3a3f6d8 
…nfiguration (airbytehq#35569)
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@stephane-airbyte @jatinyadav-cc
destination-s3: bump patch version following airbytehq#35569 (airbyte…
8a1d736 
…hq#35576)

Co-authored-by: Stephane Geneix <stephane@airbyte.io>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@stephane-airbyte @jatinyadav-cc
destination-snowflake: bump patch version following airbytehq#35569 (a…
f44515f 
…irbytehq#35575)

Co-authored-by: Stephane Geneix <stephane@airbyte.io>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@stephane-airbyte @jatinyadav-cc
destination-bigquery: bump patch version following airbytehq#35569 (a…
2371cb3 
…irbytehq#35574)

Co-authored-by: Stephane Geneix <stephane@airbyte.io>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@stephane-airbyte @jatinyadav-cc
source-mysql: bump patch version following airbytehq#35569 (airbytehq…
e14ccf3 
…#35573)

Co-authored-by: Stephane Geneix <stephane@airbyte.io>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@stephane-airbyte @jatinyadav-cc
source-postgres: bump patch version following airbytehq#35569 (airbyt…
a95e488 
…ehq#35572)

Co-authored-by: Stephane Geneix <stephane@airbyte.io>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@stephane-airbyte @jatinyadav-cc
source-mongodb-v2: bump patch version following airbytehq#35569 (airb…
b0d9e48 
…ytehq#35571)

Co-authored-by: Stephane Geneix <stephane@airbyte.io>
xiaohansong pushed a commit that referenced this pull request Feb 27, 2024
@stephane-airbyte @xiaohansong
add entry into JAVA_OPTS to always select log4j2.xml as our logger co…
2382c87 
…nfiguration (#35569)
xiaohansong pushed a commit that referenced this pull request Feb 27, 2024
@stephane-airbyte @xiaohansong
destination-s3: bump patch version following #35569 (#35576)
459afd2 
Co-authored-by: Stephane Geneix <stephane@airbyte.io>
xiaohansong pushed a commit that referenced this pull request Feb 27, 2024
@stephane-airbyte @xiaohansong
destination-snowflake: bump patch version following #35569 (#35575)
5fcdad2 
Co-authored-by: Stephane Geneix <stephane@airbyte.io>
xiaohansong pushed a commit that referenced this pull request Feb 27, 2024
@stephane-airbyte @xiaohansong
destination-bigquery: bump patch version following #35569 (#35574)
08ff8d7 
Co-authored-by: Stephane Geneix <stephane@airbyte.io>
xiaohansong pushed a commit that referenced this pull request Feb 27, 2024
@stephane-airbyte @xiaohansong
source-mysql: bump patch version following #35569 (#35573)
b48d793 
Co-authored-by: Stephane Geneix <stephane@airbyte.io>
xiaohansong pushed a commit that referenced this pull request Feb 27, 2024
@stephane-airbyte @xiaohansong
source-postgres: bump patch version following #35569 (#35572)
4d8eefa 
Co-authored-by: Stephane Geneix <stephane@airbyte.io>
xiaohansong pushed a commit that referenced this pull request Feb 27, 2024
@stephane-airbyte @xiaohansong
source-mongodb-v2: bump patch version following #35569 (#35571)
0d40079 
Co-authored-by: Stephane Geneix <stephane@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@postamar postamar postamar approved these changes

@xiaohansong xiaohansong xiaohansong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephane-airbyte @postamar @xiaohansong