Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination bigquery: upgrade cdk #35315

Merged
merged 10 commits into from
Mar 4, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
format
  • Loading branch information
edgao authored and gisripa committed Mar 4, 2024
commit b73ecdd0019f2ee94538886f5e59840c948d4e7a
Original file line number Diff line number Diff line change
Expand Up @@ -450,8 +450,7 @@ private TyperDeduper buildTyperDeduper(final BigQuerySqlGenerator sqlGenerator,
final BigQueryV2TableMigrator v2RawTableMigrator = new BigQueryV2TableMigrator(bigquery);
final BigQueryDestinationHandler destinationHandler = new BigQueryDestinationHandler(
bigquery,
datasetLocation
);
datasetLocation);

if (disableTypeDedupe) {
return new NoOpTyperDeduperWithV1V2Migrations<>(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -430,15 +430,16 @@ public void noCrashOnSpecialCharacters(final String specialChars) throws Excepti
}

/**
* Bigquery doesn't handle frequent INSERT/DELETE statements on a single table very well.
* So we don't have real state handling. Disable this test.
* Bigquery doesn't handle frequent INSERT/DELETE statements on a single table very well. So we
* don't have real state handling. Disable this test.
*/
@Override
@Disabled
@Test
public void testStateHandling() throws Exception {
super.testStateHandling();
}

/**
* TableResult contains records in a somewhat nonintuitive format (and it avoids loading them all
* into memory). That's annoying for us since we're working with small test data, so just pull
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
/*
* Copyright (c) 2023 Airbyte, Inc., all rights reserved.
*/

package io.airbyte.integrations.destination.bigquery.typing_deduping;

import static org.junit.jupiter.api.Assertions.assertEquals;
Expand Down