fix e2e tests #3508
fix e2e tests #3508
Conversation
jamakase
force-pushed
the
jamakase/fix-e2e
branch
from
b8d91fe to
aa0e7da
Compare
|
|
||
| docker run -d -p 5433:5432 -e POSTGRES_PASSWORD=secret_password -e POSTGRES_DB=airbyte_ci --name airbyte_ci_pg postgres |
There was a problem hiding this comment.
Not quite sure what is a preferred approach for such cases. On the one hand, we could extend docker-compose config ( add separate docker-compose config for ci ) and start pg as part of this container, but on the other hand, the connector is not part of docker-compose config and it may be better to leave config as is - with services that are required to run airbyte only.
There was a problem hiding this comment.
i think this approach is okay for now. we should maybe just replace this with a test source / destination. doing this set up here seems like it's just a liability and distracts from what you want to test.
don't you need to stop this container when you're done those?
There was a problem hiding this comment.
Actually, we stop it on line 19 above.
Yeah, I also thought that it could be useful to have test source and destination for such cases, but I was not sure it is a better way to build one, that won't be accessible by default for other users.
What
Changes Exchange Rates Api source to postgres source.
Disables update source test as I am not sure how better address it in case of postgres. Will add separate task to add e2e test for source udpate.