-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
undo useLocalCdk = true from #34745 #35054
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
d92d5ee
to
f31d2b7
Compare
@@ -21,4 +21,6 @@ application { | |||
|
|||
dependencies { | |||
implementation 'commons-codec:commons-codec:1.16.0' | |||
|
|||
testImplementation 'org.testcontainers:mongodb:1.19.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're no longer importing the cdk from source, so the dependencies don't apply transitively any more.
/approve-and-merge reason="forgot to useLocalCdk = false before merging #34745" |
Whoops, forgot to set these to
useLocalCdk = false
before merging.