Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Source Slack bugfix: don't overwrite thread_ts in threads stream #3483

Merged
merged 4 commits into from
May 20, 2021
Merged

🎉 Source Slack bugfix: don't overwrite thread_ts in threads stream #3483

merged 4 commits into from
May 20, 2021

Conversation

htrueman
Copy link
Contributor

What

Updated tap-slack requirement to new airbyte fork version.

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

Recommended reading order

  1. setup.py

@auto-assign auto-assign bot requested review from jrhizor and michel-tricot May 19, 2021 08:35
@htrueman htrueman linked an issue May 19, 2021 that may be closed by this pull request
Source Slack: bugfix incorrect thread messages timestamp #3254
Closed
@htrueman
setup.py formatting fix.
762b5b4 
slack.md docks update.
@htrueman
Copy link
Contributor Author

htrueman commented May 19, 2021 •
edited by github-actions bot
Loading

/test connector=source-slack-singer

🕑 source-slack-singer https://github.com/airbytehq/airbyte/actions/runs/856247832
✅ source-slack-singer https://github.com/airbytehq/airbyte/actions/runs/856247832

Zirochkaa
Zirochkaa approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@Zirochkaa Zirochkaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@htrueman
Copy link
Contributor Author

htrueman commented May 19, 2021 •
edited by github-actions bot
Loading

/test connector=source-slack-singer

🕑 source-slack-singer https://github.com/airbytehq/airbyte/actions/runs/856571677
✅ source-slack-singer https://github.com/airbytehq/airbyte/actions/runs/856571677

@htrueman htrueman requested a review from sherifnada May 19, 2021 13:36
@htrueman
Copy link
Contributor Author

htrueman commented May 19, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-slack-singer

🕑 connectors/source-slack-singer https://github.com/airbytehq/airbyte/actions/runs/857280505
✅ connectors/source-slack-singer https://github.com/airbytehq/airbyte/actions/runs/857280505

@sherifnada sherifnada changed the title setup.py install_requirements updated 🎉 Source Slack bugfix: don't overwrite thread_ts in threads stream May 19, 2021
@htrueman htrueman merged commit f9feb2e into master May 20, 2021
@htrueman htrueman deleted the htrueman/source-slack-singer-tap-update branch May 20, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@po3na4skld po3na4skld po3na4skld approved these changes

@Zirochkaa Zirochkaa Zirochkaa approved these changes

@sherifnada sherifnada sherifnada approved these changes

@keu keu keu approved these changes

@arhip11 arhip11 Awaiting requested review from arhip11

@yevhenii-ldv yevhenii-ldv Awaiting requested review from yevhenii-ldv

@vitaliizazmic vitaliizazmic Awaiting requested review from vitaliizazmic

@jrhizor jrhizor Awaiting requested review from jrhizor

@michel-tricot michel-tricot Awaiting requested review from michel-tricot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Slack: bugfix incorrect thread messages timestamp
5 participants
@htrueman @keu @sherifnada @Zirochkaa @po3na4skld