Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination snowflake: Update to latest cdk #34612

Merged
merged 5 commits into from
May 7, 2024
Merged

Destination snowflake: Update to latest cdk #34612

merged 5 commits into from
May 7, 2024

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Jan 29, 2024 •
edited
Loading

tests passing, ptal

@vercel Vercel
Copy link

vercel bot commented Jan 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 10:43pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jan 29, 2024
This was referenced Jan 29, 2024
Closed
Closed
Closed
@edgao Graphite App
Copy link
Contributor Author

edgao commented Jan 29, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @edgao and the rest of your teammates on Graphite Graphite

@edgao edgao mentioned this pull request Jan 29, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@edgao edgao mentioned this pull request Jan 29, 2024
Merged
This was referenced Jan 29, 2024
Closed
Closed
@edgao edgao changed the base branch from dv2/mysql_base to dv2/td_tests_allow_unsafe_cast January 29, 2024 18:15
@edgao edgao force-pushed the dv2/mysql_snowflake branch 2 times, most recently from f707f36 to 219e5bd Compare January 29, 2024 23:38
@edgao edgao force-pushed the dv2/td_tests_allow_unsafe_cast branch from 9a43f6a to c57e51f Compare January 30, 2024 17:36
@edgao edgao force-pushed the dv2/mysql_snowflake branch 2 times, most recently from e6f982e to ab50a49 Compare January 30, 2024 22:02
@edgao edgao force-pushed the dv2/td_tests_allow_unsafe_cast branch 5 times, most recently from 70df4d0 to fa1d379 Compare February 1, 2024 18:17
@edgao edgao force-pushed the dv2/td_tests_allow_unsafe_cast branch 2 times, most recently from ff3bd11 to 38b5a37 Compare February 1, 2024 23:56
@edgao edgao force-pushed the dv2/td_tests_allow_unsafe_cast_2 branch from be36130 to 9bb61fe Compare May 3, 2024 20:07
Base automatically changed from dv2/td_tests_allow_unsafe_cast_2 to master May 3, 2024 20:29
@edgao edgao force-pushed the dv2/mysql_snowflake branch 3 times, most recently from 5ea1a88 to 2390b7c Compare May 3, 2024 22:32
@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label May 3, 2024
@edgao edgao force-pushed the dv2/mysql_snowflake branch 3 times, most recently from 7232448 to 67d2f4d Compare May 3, 2024 23:17
@edgao edgao marked this pull request as ready for review May 3, 2024 23:17
@edgao edgao requested a review from a team as a code owner May 3, 2024 23:17
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 7, 2024
@edgao edgao enabled auto-merge (squash) May 7, 2024 20:55
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label May 7, 2024
@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label May 7, 2024
@edgao edgao merged commit 3e609f1 into master May 7, 2024
34 checks passed
@edgao edgao deleted the dv2/mysql_snowflake branch May 7, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephane-airbyte stephane-airbyte stephane-airbyte approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/snowflake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edgao @stephane-airbyte @octavia-squidington-iii