-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹doc: update connectors README and remove acceptance-test-docker.sh #32209
🧹doc: update connectors README and remove acceptance-test-docker.sh #32209
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Is there a template we need to update as well?
|
/approve-and-merge reason="doc only update triggering connector tests" |
Looks like the Iterable README got mixed up with the Coinmarketcap README? Happy to make a PR. just want to confirm. |
@AF414 yes indeed! Sorry for this. Feel free to make the PR and ask a review from me. |
What
Relates to #30767
Our connectors README were stale because:
airbyte-ci
, which makes its Dockerfile andacceptance-test-docker.sh
script legacyHow
acceptance-test-docker.sh
scripts