-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Amplitude: fix datetime update and session length change #28942
base: master
Are you sure you want to change the base?
Changes from all commits
9c3e2c1
689657f
ff44713
fb3e464
953bc45
1fe733e
a92246e
b9e613b
eb9ff2b
9ed1c6d
707127c
425a7da
7e25160
e072a2f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,7 +34,7 @@ def extract_records(self, response: requests.Response) -> List[Record]: | |
series = response_data.get("series", []) | ||
if len(series) > 0: | ||
series = series[0] # get the nested list | ||
return [{"date": date, "length": length} for date, length in zip(response_data["xValues"], series)] | ||
return [{"date": date, "length": length["value"]} for date, length in zip(response_data["xValues"], series)] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why doesn't the change from using There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Synced with Maxime, Amplitude response has also changed (but not documented) that has changed what was original an array of numbers:
to an array of objects:
We need this to retain compatibility with our existing connector behavior so this is all good. |
||
return [] | ||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just cleaning up naming but doesn't affect this PR