Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source SurveyMonkey: add survey_collectors and collectors stream #23721

Merged
merged 14 commits into from
Apr 27, 2023
Merged

🎉 Source SurveyMonkey: add survey_collectors and collectors stream #23721

merged 14 commits into from
Apr 27, 2023

Conversation

domzae
Copy link
Contributor

@domzae domzae commented Mar 3, 2023

What

Adds survey_collectors stream. "Collectors" are groupings of surveys (for example a specific link to a survey).

How

Only added full-refresh.

Recommended reading order

  1. source.py
  2. streams.py
  3. tests

🚨 User Impact 🚨

No

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@domzae domzae changed the title Source SurveyMonkey: add survey_collectors stream 🎉 Source SurveyMonkey: add survey_collectors stream Mar 3, 2023
@sh4sh
Copy link
Contributor

sh4sh commented Apr 14, 2023

/test connector=connectors/source-surveymonkey

🕑 connectors/source-surveymonkey https://github.com/airbytehq/airbyte/actions/runs/4700841707
❌ connectors/source-surveymonkey https://github.com/airbytehq/airbyte/actions/runs/4700841707
🐛 https://gradle.com/s/64735jl3j2kd4

Build Failed

Test summary info:

Could not find result summary

@marcosmarxm marcosmarxm self-assigned this Apr 14, 2023
@marcosmarxm marcosmarxm changed the title 🎉 Source SurveyMonkey: add survey_collectors stream 🎉 Source SurveyMonkey: add survey_collectors and collectors stream Apr 19, 2023
@marcosmarxm
Copy link
Member

/test connector=connectors/source-surveymonkey

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @domzae

@marcosmarxm
Copy link
Member

marcosmarxm commented Apr 19, 2023

/test connector=connectors/source-surveymonkey

🕑 connectors/source-surveymonkey https://github.com/airbytehq/airbyte/actions/runs/4745410469
✅ connectors/source-surveymonkey https://github.com/airbytehq/airbyte/actions/runs/4745410469
Python tests coverage:

Name                              Stmts   Miss  Cover
-----------------------------------------------------
source_surveymonkey/__init__.py       2      0   100%
source_surveymonkey/streams.py      153     14    91%
source_surveymonkey/source.py        65     13    80%
-----------------------------------------------------
TOTAL                               220     27    88%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================== 40 passed, 1 skipped in 280.52s (0:04:40) ===================

@marcosmarxm
Copy link
Member

marcosmarxm commented Apr 26, 2023

/publish connector=connectors/source-surveymonkey

🕑 Publishing the following connectors:
connectors/source-surveymonkey
https://github.com/airbytehq/airbyte/actions/runs/4813236964


Connector Version Did it publish? Were definitions generated?
connectors/source-surveymonkey 0.2.0

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@marcosmarxm marcosmarxm merged commit cb593fa into airbytehq:master Apr 27, 2023
marcosmarxm added a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
airbytehq#23721)

* add survey_collectors stream

* add stream to docs

* add missing schema

* fix stream and add expected records

* remove unused file

* bump connector version

* fix unit test

* add doc url for surveycollectors

* update expected records

* auto-bump connector version

---------

Co-authored-by: sh4sh <6833405+sh4sh@users.noreply.github.com>
Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants