-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert the server to micronaut #19194
Merged
Merged
Changes from 42 commits
Commits
Show all changes
143 commits
Select commit
Hold shift + click to select a range
7027679
Extract Operation API
benmoriceau eb18779
Extract scheduler API
benmoriceau 05ffc3a
Format
benmoriceau 09d63e5
Merge branch 'bmoric/extract-operation-api' of github.com:airbytehq/a…
benmoriceau 585a8a9
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/ext…
benmoriceau 6fc0a85
Merge branch 'bmoric/extract-operation-api' of github.com:airbytehq/a…
benmoriceau 97b33a1
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/ext…
benmoriceau 88c2557
extract source api
benmoriceau 4f799f5
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/ext…
benmoriceau af86517
Extract source definition api
benmoriceau c76ed4e
Add path
benmoriceau 6a57dcc
Extract State API
benmoriceau 30b991d
extract webbackend api
benmoriceau c72225d
extract webbackend api
benmoriceau ecad901
extract workspace api
benmoriceau 1cf081b
Extract source definition specification api
benmoriceau e1649ab
Remove configuration API
benmoriceau 7bb500b
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/ext…
benmoriceau 0962577
Merge branch 'master' into bmoric/extract-source-definition-specifica…
benmoriceau 025b12b
Merge branch 'bmoric/extract-source-definition-specification-api' of …
benmoriceau 4582738
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/rm-…
benmoriceau 35a8624
tmp
benmoriceau f8452dd
Checkstyle
benmoriceau 3d8948d
tmp
benmoriceau a4a5b5d
tmp
benmoriceau 7639d5d
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau 470f637
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau abfd514
Inject but don't resolve Bean
benmoriceau 46c9d8e
tmp
benmoriceau b67653c
Tmp
benmoriceau b6b397e
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau 3b5b39c
fix build
benmoriceau 1358315
TMP
benmoriceau 1a60f15
Tmp
benmoriceau 6229c09
Clean up
benmoriceau e24a488
better thread pool
benmoriceau 0d8ae2f
Change port to 8080
benmoriceau ce1932e
Fix port
benmoriceau 6c4da77
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau f5b23cf
Rm unused
benmoriceau bba0af8
Cors filter
benmoriceau 5e2c9a5
Format
benmoriceau 002a39e
rename
benmoriceau 4d36cd1
Tmp
benmoriceau f5cbc7b
Config based
benmoriceau 3b2e18a
Rm health controller ref
benmoriceau bad7f07
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau d3aecda
tmp
benmoriceau 8f03443
Pool size
benmoriceau 4666776
Mock healthcheck
benmoriceau 267094a
Revert "Mock healthcheck"
benmoriceau 95fa38c
Revert "Revert "Mock healthcheck""
benmoriceau 245dd11
Restore health check
benmoriceau c237c8e
Tmp
benmoriceau 4447ba8
format
benmoriceau 57b0af8
Rm deprecated
benmoriceau 8fef069
Fix PMD
benmoriceau 44146ef
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau 77ff93a
Tmp
benmoriceau 1c84878
Fix proxy test
benmoriceau a3fadde
Remove useless annotation
benmoriceau 03d902a
set auto commit as false
benmoriceau caef0f6
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau 3c55fb0
Clean up and PR comments
benmoriceau 92a5efa
Bmoric/convert attempt micronaut (#19847)
benmoriceau 1dd8988
Comments and banner
benmoriceau 6542588
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau 1d5ccae
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau 8402ffd
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau f78b7ac
Non related files
benmoriceau 04a2cac
rm tmp
benmoriceau 2eece6d
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau eb31d50
Fix build
benmoriceau a91d26b
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau 018d3dd
Format
benmoriceau d50555d
Hit the micronaut server directly
benmoriceau ce9127e
micronaut OperationApiController (#20270)
colesnodgrass 01d5ebc
Bmoric/convert connection micronaut (#20211)
benmoriceau fa87e26
Bmoric/convert destination controller micronaut (#20269)
benmoriceau cb5d151
Bmoric/convert destination definition controller micronaut (#20277)
benmoriceau d35f939
convert StateApiController to Micronaut (#20329)
colesnodgrass db06338
Move dest oauth to micronaut (#20318)
benmoriceau 711a7c7
Bmoric/convert source micronaut (#20334)
benmoriceau 45cac68
Migrate to micronaut (#20339)
benmoriceau 06c0af8
Migrate source to micronaut
benmoriceau ae5fad3
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau f801280
convert SchedulerApiController to Micronaut (#20337)
colesnodgrass 9fe2319
Bmoric/convert source definition micronaut (#20338)
benmoriceau fe595fb
update SourceOauthApiController to Micronaut (#20386)
colesnodgrass e9484a5
convert WorkspaceApiController to micronaut (#20214)
colesnodgrass 1f257ed
Bmoric/convert jobs micronaut (#20382)
benmoriceau 013135e
Bmoric/convert source definition specification micronaut (#20379)
benmoriceau 38314dc
convert database assert call to Micronaut (#20406)
colesnodgrass ae2e034
convert NotificationsApiController to Micronaut (#20396)
colesnodgrass a8c11d2
Migrate logs to micronaut (#20400)
benmoriceau 6a480ef
Bmoric/convert webbackend micronaut (#20403)
benmoriceau c0682a3
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau 5d13c4c
Cleanup (#20459)
benmoriceau fcb271d
Delete logs API
benmoriceau 990a681
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau 60cbe90
Revert "Delete logs API"
benmoriceau a43f2d3
Rm flaky test
benmoriceau f001bdb
Format
benmoriceau 97dd2df
Try to fix test
benmoriceau 53f30c5
Format
benmoriceau c0a9ebc
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau 3e2c92f
Remove optional
benmoriceau f085d82
Rm import
benmoriceau ddf7228
Test sleep
benmoriceau 33c5842
Simplify injection
benmoriceau ab6fead
update import
benmoriceau 44caebb
Remove sleep
benmoriceau d2029e4
More injection
benmoriceau fb153cc
Remove more requirement
benmoriceau 2f5602e
imports
benmoriceau bf8586e
Remove more requirement
benmoriceau 250a6b3
Fix yaml
benmoriceau c390464
Remove unused conf
benmoriceau 624edd9
Add role
benmoriceau e6e04f1
Test acceptance test
benmoriceau ad554f1
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau 19a1603
Update env
benmoriceau 09ff988
Revert "Update to Micronaut 3.8.0 (#20716)"
benmoriceau c183e67
Update helm chart
benmoriceau 446f8c2
Fix helm chart
benmoriceau d4b4d49
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau 55b1499
Convert Application Listener
benmoriceau 18ebd34
Format
benmoriceau 90e1ebe
Add explicit deployment mode
benmoriceau 95d1c24
Change check port
benmoriceau f7c1e0c
Update version and bump version to the right value
benmoriceau dcb85ec
Cleanup
benmoriceau ecc6798
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau 777270a
Update FE end to end test
benmoriceau 24cd7a8
Allow head request
benmoriceau d943232
Merge branch 'master' into bmoric/convert-health-micronaut
benmoriceau 80264fd
Merge branch 'master' into bmoric/convert-health-micronaut
benmoriceau d046c55
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau 2e282b9
Fix controller
benmoriceau 61bf41b
Merge branch 'master' of github.com:airbytehq/airbyte into bmoric/con…
benmoriceau d6c7db6
Format
benmoriceau cfd8881
Fix http client Bean
benmoriceau 6e2c561
Format
benmoriceau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
airbyte-server/src/main/java/io/airbyte/server/Application.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
/* | ||
* Copyright (c) 2022 Airbyte, Inc., all rights reserved. | ||
*/ | ||
|
||
package io.airbyte.server; | ||
|
||
import io.micronaut.runtime.Micronaut; | ||
|
||
public class Application { | ||
|
||
public static void main(final String[] args) { | ||
Micronaut.run(Application.class, args); | ||
} | ||
|
||
} |
33 changes: 33 additions & 0 deletions
33
airbyte-server/src/main/java/io/airbyte/server/EventListener.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/* | ||
* Copyright (c) 2022 Airbyte, Inc., all rights reserved. | ||
*/ | ||
|
||
package io.airbyte.server; | ||
|
||
import io.micronaut.runtime.event.ApplicationStartupEvent; | ||
import io.micronaut.scheduling.TaskExecutors; | ||
import io.micronaut.scheduling.annotation.ExecuteOn; | ||
import jakarta.inject.Inject; | ||
import jakarta.inject.Singleton; | ||
import lombok.extern.slf4j.Slf4j; | ||
|
||
@Singleton | ||
@Slf4j | ||
public class EventListener { | ||
|
||
@Inject | ||
ServerRunnable serverRunnable; | ||
|
||
@io.micronaut.runtime.event.annotation.EventListener | ||
@ExecuteOn(TaskExecutors.IO) | ||
public void startEmitters(final ApplicationStartupEvent event) { | ||
try { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is what used to be in the main of the serverApp |
||
log.error("Starting server"); | ||
|
||
serverRunnable.start(); | ||
} catch (final Exception e) { | ||
throw new RuntimeException(e); | ||
} | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is temporary, the values needed will be move to the handler creation as they are needed (the health check doesn't need any)