Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore .stories.tsx for coverage reports #16646

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Ignore .stories.tsx for coverage reports #16646

merged 1 commit into from
Sep 13, 2022

Conversation

krishnaglick
Copy link
Contributor

What

Jest coverage was reporting for .stories.tsx files.

How

.stories.tsx was added to jest coverage ignore.

@krishnaglick krishnaglick requested a review from a team September 13, 2022 15:46
@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Sep 13, 2022
teallarson
teallarson reviewed Sep 13, 2022
View reviewed changes
Copy link
Contributor

@teallarson teallarson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are node_modules excluded by default? I'd think so? Are there other items to exclude? (maybe test utilities/mocks)

@teallarson teallarson self-requested a review September 13, 2022 18:33
teallarson
teallarson approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@teallarson teallarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chatted while pairing, this is helpful for now!

@krishnaglick krishnaglick merged commit e419e0f into master Sep 13, 2022
@krishnaglick krishnaglick deleted the kc/dont-use-story-files-for-coverage-reporting branch September 13, 2022 18:35
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
@krishnaglick @robbinhan
Ignore .stories.tsx for coverage reports (airbytehq#16646)
9a27fef
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@krishnaglick @jhammarstedt
Ignore .stories.tsx for coverage reports (airbytehq#16646)
22b040a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teallarson teallarson teallarson approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krishnaglick @teallarson