-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove -alpha
tags from Airbyte release versions
#15766
Conversation
It is expected that the Ensure all required Docker images exist on Dockerhub action fail until we release the next version of OSS... which we should do immediately after this PR is merged. |
-alpha
tags from Airbyte release versions
@davinchia I think that the OSS version names don't matter too much for cloud deployments any more (https://github.com/airbytehq/airbyte-cloud/pull/2332/) as the SHA is what is used now. Can you please confirm that the changes here will be OK for cloud? |
@evantahler ack. will take a look later today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like a good change to me.
I think removing alpha makes sense for external communication.
I added Peter who has context on bump version in infra
version: placeholder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks right to me!
My understanding is also that Cloud has been updated to take refs, so we should be good now.
Honestly, it's tough to test these things so.. I would just go for it. I'm available tomorrow to pair on ironing out kinks (if any).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Also, cloud references oss based on commit sha or git tags, and in the case of tags it doesn't assume anything about the structure/format of the tag name other than that the tag starts with a v
, so this change should be fully compatible with cloud
Closes #14022
This PR removes
-alpha
from the Airbyte versions and releases. As we are using Semver and on a pre-v1, we are already broadcasting that we have an unstable (read: rapidly changing) product and API. Airbyte has thousands of companies using the product already, both on-prem and via Airbyte cloud, so the-alpha
label is no longer appropriate.We use the
bumpversion
tool to bump the version numbers in various files via therelease_version
action, running thebump_version
script. This PR updates the bumpversion config file and removes the trailing-alpha
tags from versioned files.Note: Once this PR is merged, we will be able to release another OSS patch release, which should update all these files to
0.40.1
(next version) (no-alpha
)This PR is hard to test, but you can check out this branch locally and then run
bumpversion patch
and see the changes: