Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -alpha tags from Airbyte release versions #15766

Merged
merged 5 commits into from
Aug 22, 2022
Merged

Conversation

evantahler
Copy link
Contributor

@evantahler evantahler commented Aug 18, 2022

Closes #14022

This PR removes -alpha from the Airbyte versions and releases. As we are using Semver and on a pre-v1, we are already broadcasting that we have an unstable (read: rapidly changing) product and API. Airbyte has thousands of companies using the product already, both on-prem and via Airbyte cloud, so the -alpha label is no longer appropriate.

We use the bumpversion tool to bump the version numbers in various files via the release_version action, running the bump_version script. This PR updates the bumpversion config file and removes the trailing -alpha tags from versioned files.

Note: Once this PR is merged, we will be able to release another OSS patch release, which should update all these files to 0.40.1 (next version) (no -alpha)

This PR is hard to test, but you can check out this branch locally and then run bumpversion patch and see the changes:

diff --git a/.bumpversion.cfg b/.bumpversion.cfg
index 5ffda3c5a0..decd983c4b 100644
--- a/.bumpversion.cfg
+++ b/.bumpversion.cfg
@@ -1,9 +1,9 @@
 [bumpversion]
-current_version = 0.40.0
+current_version = 0.40.1
 commit = False
 tag = False
 parse = (?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)(\-[a-z]+)?

 [bumpversion:file:.bumpversion.cfg]
diff --git a/.env b/.env
index 9e1e7b3897..bb69ee03f8 100644
--- a/.env
+++ b/.env
@@ -10,7 +10,7 @@


 ### SHARED ###
-VERSION=0.40.0
+VERSION=0.40.1

 # When using the airbyte-db via default docker image
 CONFIG_ROOT=/data
diff --git a/airbyte-bootloader/Dockerfile b/airbyte-bootloader/Dockerfile
index 149c829e4c..299372b22b 100644
--- a/airbyte-bootloader/Dockerfile
+++ b/airbyte-bootloader/Dockerfile
@@ -2,7 +2,7 @@ ARG JDK_VERSION=19-slim-bullseye
 ARG JDK_IMAGE=openjdk:${JDK_VERSION}
 FROM ${JDK_IMAGE}

-ARG VERSION=0.40.0
+ARG VERSION=0.40.1

 ENV APPLICATION airbyte-bootloader
 ENV VERSION ${VERSION}
diff --git a/airbyte-container-orchestrator/Dockerfile b/airbyte-container-orchestrator/Dockerfile
index 32558a97f5..1196cb40b0 100644
--- a/airbyte-container-orchestrator/Dockerfile
+++ b/airbyte-container-orchestrator/Dockerfile
@@ -28,7 +28,7 @@ RUN echo "deb [signed-by=/usr/share/keyrings/kubernetes-archive-keyring.gpg] htt
 RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y kubectl

 # Don't change this manually.  Bump version expects to make moves based on this string
-ARG VERSION=0.40.0
+ARG VERSION=0.40.1

 ENV APPLICATION airbyte-container-orchestrator
 ENV VERSION=${VERSION}
diff --git a/airbyte-metrics/reporter/Dockerfile b/airbyte-metrics/reporter/Dockerfile
index de12c75045..9a2713c7df 100644
--- a/airbyte-metrics/reporter/Dockerfile
+++ b/airbyte-metrics/reporter/Dockerfile
@@ -2,7 +2,7 @@ ARG JDK_VERSION=19-slim-bullseye
 ARG JDK_IMAGE=openjdk:${JDK_VERSION}
 FROM ${JDK_IMAGE} AS metrics-reporter

-ARG VERSION=0.40.0
+ARG VERSION=0.40.1

 ENV APPLICATION airbyte-metrics-reporter
 ENV VERSION ${VERSION}
diff --git a/airbyte-server/Dockerfile b/airbyte-server/Dockerfile
index 14bfdaf4f9..78ae878784 100644
--- a/airbyte-server/Dockerfile
+++ b/airbyte-server/Dockerfile
@@ -4,7 +4,7 @@ FROM ${JDK_IMAGE} AS server

 EXPOSE 8000

-ARG VERSION=0.40.0
+ARG VERSION=0.40.1

@github-actions github-actions bot added area/documentation Improvements or additions to documentation area/platform issues related to the platform area/server area/worker Related to worker kubernetes area/frontend Related to the Airbyte webapp labels Aug 18, 2022
@evantahler
Copy link
Contributor Author

It is expected that the Ensure all required Docker images exist on Dockerhub action fail until we release the next version of OSS... which we should do immediately after this PR is merged.

@evantahler evantahler changed the title Evan/no alpha Remove -alpha tags from Airbyte release versions Aug 18, 2022
@evantahler
Copy link
Contributor Author

@davinchia I think that the OSS version names don't matter too much for cloud deployments any more (https://github.com/airbytehq/airbyte-cloud/pull/2332/) as the SHA is what is used now. Can you please confirm that the changes here will be OK for cloud?

@evantahler evantahler marked this pull request as ready for review August 18, 2022 19:02
@davinchia
Copy link
Contributor

@evantahler ack. will take a look later today

@supertopher supertopher requested a review from git-phu August 18, 2022 19:35
Copy link
Contributor

@supertopher supertopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a good change to me.
I think removing alpha makes sense for external communication.

I added Peter who has context on bump version in infra

version: placeholder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@evantahler evantahler temporarily deployed to more-secrets August 18, 2022 21:31 Inactive
Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks right to me!

My understanding is also that Cloud has been updated to take refs, so we should be good now.

Honestly, it's tough to test these things so.. I would just go for it. I'm available tomorrow to pair on ironing out kinks (if any).

Copy link
Contributor

@git-phu git-phu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Also, cloud references oss based on commit sha or git tags, and in the case of tags it doesn't assume anything about the structure/format of the tag name other than that the tag starts with a v, so this change should be fully compatible with cloud

@evantahler evantahler temporarily deployed to more-secrets August 22, 2022 16:32 Inactive
@evantahler evantahler temporarily deployed to more-secrets August 22, 2022 17:13 Inactive
@evantahler evantahler merged commit 4774949 into master Aug 22, 2022
@evantahler evantahler deleted the evan/no-alpha branch August 22, 2022 18:06
rodireich pushed a commit that referenced this pull request Aug 25, 2022
* Remove alpha tags in autobump files

* remove more alpha tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation area/frontend Related to the Airbyte webapp area/platform issues related to the platform area/server area/worker Related to worker kubernetes team/platform-move
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove alpha tags from OSS Releases
4 participants