Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sweep airbyte-integrations/bases/airbyte-protocol #12598

Merged
merged 7 commits into from
May 5, 2022
Merged

sweep airbyte-integrations/bases/airbyte-protocol #12598

merged 7 commits into from
May 5, 2022

Conversation

sherifnada
Copy link
Contributor

What

It's long been deprecated by the CDK, remove it from our build toolchain

@github-actions github-actions bot added area/connectors Connector related issues CDK Connector Development Kit normalization labels May 5, 2022
@sherifnada sherifnada changed the base branch from master to sherif/cull-base-python May 5, 2022 06:56
@codecov
Copy link

codecov bot commented May 5, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@cc46255). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2664109 differs from pull request most recent head 9bbaca7. Consider uploading reports for the commit 9bbaca7 to get more accurate results

@@            Coverage Diff            @@
##             master   #12598   +/-   ##
=========================================
  Coverage          ?   83.44%           
=========================================
  Files             ?        7           
  Lines             ?      302           
  Branches          ?        0           
=========================================
  Hits              ?      252           
  Misses            ?       50           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc46255...9bbaca7. Read the comment docs.

@sherifnada sherifnada linked an issue May 5, 2022 that may be closed by this pull request
[EPIC] Completely deprecate and remove base-python and base-singer packages #6164
Closed
@sherifnada sherifnada requested a review from pedroslopez May 5, 2022 07:03
@CLAassistant
Copy link

CLAassistant commented May 5, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

pedroslopez
pedroslopez approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@pedroslopez pedroslopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏼

Base automatically changed from sherif/cull-base-python to master May 5, 2022 20:48
@sherifnada sherifnada reopened this May 5, 2022
@sherifnada sherifnada merged commit 49810f8 into master May 5, 2022
@sherifnada sherifnada deleted the sherif/cull-airbyte_protocol branch May 5, 2022 20:51
@github-actions github-actions bot removed the area/connectors Connector related issues label May 5, 2022
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request May 6, 2022
Merged
suhomud pushed a commit that referenced this pull request May 23, 2022
@sherifnada @suhomud
sweep airbyte-integrations/bases/airbyte-protocol (#12598)
5dfc6e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroslopez pedroslopez pedroslopez approved these changes

Assignees
No one assigned
Labels
CDK Connector Development Kit normalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EPIC] Completely deprecate and remove base-python and base-singer packages
4 participants
@sherifnada @CLAassistant @pedroslopez @michel-tricot