Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cull base-python and base-python-test #12596

Merged
merged 9 commits into from
May 5, 2022
Merged

cull base-python and base-python-test #12596

merged 9 commits into from
May 5, 2022

Conversation

sherifnada
Copy link
Contributor

@sherifnada sherifnada commented May 5, 2022 •
edited
Loading

What

see #6164

remove base-python, base-python-test and all dependencies from the codebase. These are no longer used.

@github-actions github-actions bot added area/connectors Connector related issues CDK Connector Development Kit labels May 5, 2022
@codecov
Copy link

codecov bot commented May 5, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@5aed8e2). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #12596   +/-   ##
=========================================
  Coverage          ?   87.44%           
=========================================
  Files             ?        5           
  Lines             ?      215           
  Branches          ?        0           
=========================================
  Hits              ?      188           
  Misses            ?       27           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aed8e2...7ae48e0. Read the comment docs.

sherifnada
sherifnada commented May 5, 2022
View reviewed changes
airbyte-cdk/python/setup.py
@@ -70,7 +70,4 @@
"sphinx-rtd-theme~=1.0",
],
},
entry_points={
Copy link
Contributor Author

@sherifnada sherifnada May 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is technically backwards breaking but i'm 99.999% sure only davin and I ever used this when we first wrote the CDK

airbyte-cdk/python/docs/tutorials/http_api_source.md Outdated Show resolved Hide resolved
@sherifnada sherifnada changed the title Sherif/cull base python cull base-python and base-python-test May 5, 2022
@sherifnada sherifnada requested a review from pedroslopez May 5, 2022 07:03
@CLAassistant
Copy link

CLAassistant commented May 5, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Base automatically changed from sherif/cull-the-old-stuff to master May 5, 2022 20:08
@sherifnada sherifnada reopened this May 5, 2022
pedroslopez
pedroslopez reviewed May 5, 2022
View reviewed changes
Copy link
Contributor

@pedroslopez pedroslopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will break the build because of usage in airbyte-source-test.gradle here:

airbyte/buildSrc/src/main/groovy/airbyte-source-test.gradle

Line 33 in 8983f09

project.airbyteDockerTest.dependsOn(':airbyte-integrations:bases:base-python-test:airbyteDocker')

will wait to approve upon removal, but looking good!

airbyte-cdk/python/docs/tutorials/http_api_source.md Outdated Show resolved Hide resolved
@sherifnada
Copy link
Contributor Author

@pedroslopez removed that whole plugin since it's not used anywhere

@sherifnada sherifnada temporarily deployed to more-secrets May 5, 2022 20:23 Inactive
@sherifnada sherifnada temporarily deployed to more-secrets May 5, 2022 20:23 Inactive
@sherifnada sherifnada merged commit cc46255 into master May 5, 2022
@sherifnada sherifnada deleted the sherif/cull-base-python branch May 5, 2022 20:48
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request May 6, 2022
Merged
suhomud pushed a commit that referenced this pull request May 23, 2022
@sherifnada @suhomud
cull base-python and base-python-test (#12596)
c2cf210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroslopez pedroslopez pedroslopez approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues CDK Connector Development Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sherifnada @CLAassistant @pedroslopez @michel-tricot