Adding VS Code settings to project workspace #12319
Conversation
|
|
.vscode/settings.json
Outdated
| "editor.codeActionsOnSave": { | ||
| "source.organizeImports": true | ||
| } |
There was a problem hiding this comment.
Ahh, so here's a difference. I let eslint organize the imports instead of vscode. I'm not sure if they sort the same way. We already have an 'import/order' rule in the .eslintrc file.
There was a problem hiding this comment.
VS Code actually does slightly better when it comes to organizing, but it doesn't do any grouping like eslint. They don't clash at least. 🤷
There was a problem hiding this comment.
Not all of us are strictly using vscode, either, so it should respect whatever eslint is doing because if we eslint --fix in the future it will change things around.
There was a problem hiding this comment.
True. I'll turn it off.
I open it at that level too typically. |
I do not, not sure these settings will load properly if you do. But I can say they don't work if I put them in |
| "editor.defaultFormatter": "esbenp.prettier-vscode" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
@edmundito This gives us the option to use root, or the workspace.
I'm of two minds:
Doing this is nice as it's then up to the developer to pick.
But if these settings change we'll have to make sure they stay synced. I don't anticipate them changing much after this PR goes in however.
The only other win I see is if someone hops in to do some OSS contributions it'll work as long as they don't open just the sub-folder they need.
Opening the root folder will prompt them to open the workspace at least.
* First pass * Code Review changes * Adding a code workspace * Adding extension recommendations
What
Adds specific workspace settings so frontend work is more consistent across VS Code instances.