Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local_json, Maridb, Meilisearch, Mongodb, Mqtt destinations : Enable DAT tests #12073

Merged
merged 21 commits into from
Apr 19, 2022
Merged

Local_json, Maridb, Meilisearch, Mongodb, Mqtt destinations : Enable DAT tests #12073

merged 21 commits into from
Apr 19, 2022

Conversation

DoNotPanicUA
Copy link
Contributor

What

Enable DAT tests #9443

  • Destination Local_json
  • Destination Maridb
  • Destination Meilisearch
  • Destination Mongodb
  • Destination Mqtt

Recommended reading order

  1. x.java
  2. y.python

@DoNotPanicUA
add Boolean, Number, DateTimeWithTZ compare methods
44a6d81
@DoNotPanicUA
Merge remote-tracking branch 'origin/master' into aleonets/add-dat-te…
656148a 
…sts-ph1
@DoNotPanicUA
Improve value comparison
46c3a1b
@DoNotPanicUA
Merge remote-tracking branch 'origin/master' into aleonets/add-dat-te…
2a4b384 
…sts-ph1
@DoNotPanicUA
Compare inherit objects element by element
cd53764
@DoNotPanicUA
Merge remote-tracking branch 'origin/aleonets/add-dat-tests-ph1' into…
4cd50de 
… aleonets/add-dat-tests-ph1
@DoNotPanicUA
Move comparison methods to a new class not to overload the test class.
3c911c9 
Basic - old implementation which provides backward compatibility of this PR.
Advanced - comparator required for destinations with enabled DAT tests.
@DoNotPanicUA
format
f28b9af
@DoNotPanicUA
Merge remote-tracking branch 'origin/master' into aleonets/add-dat-te…
af1cff8 
…sts-ph1
@DoNotPanicUA
Merge remote-tracking branch 'origin/master' into aleonets/add-dat-te…
06764b2 
…sts-ph1
@DoNotPanicUA
Move common method to ComparatorUtils. + Review update
4ddee6c
@DoNotPanicUA
format
127b4ba
@DoNotPanicUA
review
ed890d3
@DoNotPanicUA
Merge remote-tracking branch 'origin/master' into aleonets/add-dat-te…
4007837 
…sts-ph1
@DoNotPanicUA
review
f1e860b
@DoNotPanicUA
mark resolveIdentifier method as deprecated
5b59eb1
@DoNotPanicUA
remove size objects validation. We iterate expected elements and comp…
c2106a4 
…are it with actualObject elements. Expected might have empty elements and they are equal missing element in the actual Object. Also, actualObject might contain additional elements which is not an exception.
@DoNotPanicUA
Merge remote-tracking branch 'origin/master' into aleonets/add-dat-te…
28625d6 
…sts-ph1
@DoNotPanicUA
Merge remote-tracking branch 'origin/master' into aleonets/add-dat-te…
bf9b84c 
…sts-ph1
@DoNotPanicUA
enable DAT tests for local_json, maridb, meilisearch, mongodb, mqtt
cb2bac6
@github-actions github-actions bot added the area/connectors Connector related issues label Apr 15, 2022
@DoNotPanicUA DoNotPanicUA linked an issue Apr 15, 2022 that may be closed by this pull request
Write DAT(s) that test different type combinations #9443
Closed
@DoNotPanicUA DoNotPanicUA removed a link to an issue Apr 15, 2022
Write DAT(s) that test different type combinations #9443
Closed
@DoNotPanicUA DoNotPanicUA linked an issue Apr 15, 2022 that may be closed by this pull request
Run the new DAT(s) against all destinations and find destinations that are not compliant #9444
Closed
@DoNotPanicUA
Copy link
Contributor Author

DoNotPanicUA commented Apr 15, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-local_json

🕑 connectors/destination-local_json https://github.com/airbytehq/airbyte/actions/runs/2173165358
❌ connectors/destination-local_json https://github.com/airbytehq/airbyte/actions/runs/2173165358
🐛

@DoNotPanicUA
Copy link
Contributor Author

DoNotPanicUA commented Apr 15, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-local-json

🕑 connectors/destination-local-json https://github.com/airbytehq/airbyte/actions/runs/2173166851
✅ connectors/destination-local-json https://github.com/airbytehq/airbyte/actions/runs/2173166851
No Python unittests run

@DoNotPanicUA
Copy link
Contributor Author

DoNotPanicUA commented Apr 15, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-mariadb-columnstore

🕑 connectors/destination-mariadb-columnstore https://github.com/airbytehq/airbyte/actions/runs/2173168017

@DoNotPanicUA
Copy link
Contributor Author

DoNotPanicUA commented Apr 15, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-meilisearch

🕑 connectors/destination-meilisearch https://github.com/airbytehq/airbyte/actions/runs/2173168678
✅ connectors/destination-meilisearch https://github.com/airbytehq/airbyte/actions/runs/2173168678
No Python unittests run

@DoNotPanicUA
Copy link
Contributor Author

DoNotPanicUA commented Apr 15, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-mongodb

🕑 connectors/destination-mongodb https://github.com/airbytehq/airbyte/actions/runs/2173169389
✅ connectors/destination-mongodb https://github.com/airbytehq/airbyte/actions/runs/2173169389
No Python unittests run

@DoNotPanicUA
Copy link
Contributor Author

DoNotPanicUA commented Apr 15, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-mqtt

🕑 connectors/destination-mqtt https://github.com/airbytehq/airbyte/actions/runs/2173170109
❌ connectors/destination-mqtt https://github.com/airbytehq/airbyte/actions/runs/2173170109
🐛 https://gradle.com/s/bwjhcl6polu3s

@DoNotPanicUA
Copy link
Contributor Author

DoNotPanicUA commented Apr 19, 2022 •
edited
Loading

/test connector=connectors/destination-mqtt

🕑 connectors/destination-mqtt https://github.com/airbytehq/airbyte/actions/runs/2189045794
❌ connectors/destination-mqtt https://github.com/airbytehq/airbyte/actions/runs/2189045794
🐛 https://gradle.com/s/rlzpxxfmd7flo

DAT tests finished without errors. Failed old test which is not a part of the PR scope

@DoNotPanicUA
Copy link
Contributor Author

DoNotPanicUA commented Apr 19, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-mongodb

🕑 connectors/destination-mongodb https://github.com/airbytehq/airbyte/actions/runs/2189046355
✅ connectors/destination-mongodb https://github.com/airbytehq/airbyte/actions/runs/2189046355
No Python unittests run

@DoNotPanicUA
Copy link
Contributor Author

DoNotPanicUA commented Apr 19, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-meilisearch

🕑 connectors/destination-meilisearch https://github.com/airbytehq/airbyte/actions/runs/2189046877
✅ connectors/destination-meilisearch https://github.com/airbytehq/airbyte/actions/runs/2189046877
No Python unittests run

@DoNotPanicUA
Copy link
Contributor Author

DoNotPanicUA commented Apr 19, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-local-json

🕑 connectors/destination-local-json https://github.com/airbytehq/airbyte/actions/runs/2189047684
✅ connectors/destination-local-json https://github.com/airbytehq/airbyte/actions/runs/2189047684
No Python unittests run

@DoNotPanicUA DoNotPanicUA marked this pull request as ready for review April 19, 2022 14:50
@DoNotPanicUA DoNotPanicUA merged commit c8c4cf5 into master Apr 19, 2022
@DoNotPanicUA DoNotPanicUA deleted the aleonets/dat-LM branch April 19, 2022 14:54
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Apr 19, 2022
Merged
suhomud pushed a commit that referenced this pull request May 23, 2022
@DoNotPanicUA @suhomud
Local_json, Maridb, Meilisearch, Mongodb, Mqtt destinations : Enable…
2501cc8 
… DAT tests (#12073)

* add Boolean, Number, DateTimeWithTZ compare methods

* Improve value comparison

* Compare inherit objects element by element

* Move comparison methods to a new class not to overload the test class.
Basic - old implementation which provides backward compatibility of this PR.
Advanced - comparator required for destinations with enabled DAT tests.

* format

* Move common method to ComparatorUtils. + Review update

* format

* review

* review

* mark resolveIdentifier method as deprecated

* remove size objects validation. We iterate expected elements and compare it with actualObject elements. Expected might have empty elements and they are equal missing element in the actual Object. Also, actualObject might contain additional elements which is not an exception.

* enable DAT tests for local_json, maridb, meilisearch, mongodb, mqtt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashaNeshcheret sashaNeshcheret sashaNeshcheret approved these changes

@alexandr-shegeda alexandr-shegeda Awaiting requested review from alexandr-shegeda

Assignees
No one assigned
Labels
area/connectors Connector related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run the new DAT(s) against all destinations and find destinations that are not compliant
2 participants
@DoNotPanicUA @sashaNeshcheret