Skip to content

Conversation

grishick
Copy link
Contributor

@grishick grishick commented Mar 4, 2022

What

Requirements for running Airbyte locally include Postgres, which is no longer required
Instructions for running acceptance tests do not take into account that test containers manage their own Airbyte deployment

How

  • Remove requirement for local Postgres, because it is no longer needed
  • Fix bash code snippet for running acceptance tests (remove the line that starts Airbyte)
  • Document how to use USE_EXTERNAL_DEPLOYMENT flag

1) Remove requirement for local Postgres, because it is no longer needed
2) Fix bash code snippet for running acceptance tests (remove the line that starts Airbyte)
3) Document how to use USE_EXTERNAL_DEPLOYMENT flag
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Mar 4, 2022
@grishick grishick requested a review from sherifnada March 4, 2022 02:23
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for making onboarding better for the next engineer!

@grishick grishick temporarily deployed to more-secrets March 4, 2022 02:26 Inactive
@grishick grishick merged commit 1c41517 into master Mar 4, 2022
@grishick grishick deleted the grishick-patch-1 branch March 4, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants