Skip to content

Commit

Permalink
add connector checklist item about annotating secrets (#3895)
Browse files Browse the repository at this point in the history

Co-authored-by: Christophe Duong <christophe.duong@gmail.com>

Co-authored-by: Christophe Duong <christophe.duong@gmail.com>
  • Loading branch information
sherifnada and ChristopheDuong authored Jun 4, 2021
1 parent b869c40 commit 85425f8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@ Expand the checklist which is relevant for this PR.
<p>

- [ ] Issue acceptance criteria met
- [ ] Secrets are annotated with `airbyte_secret` in output spec
- [ ] Unit & integration tests added as appropriate (and are passing)
* Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run `./gradlew :airbyte-integrations:connectors:<name>:integrationTest`.
- [ ] `/test` command documented [here]() is passing.
- [ ] `/test connector=connectors/<name>` command as documented [here](https://docs.airbyte.io/contributing-to-airbyte/building-new-connector#updating-an-existing-connector) is passing.
* Community members can skip this, Airbyters will run this for you.
- [ ] Code reviews completed
- [ ] Credentials added to Github CI if needed and not already present. [instructions for injecting secrets into CI](https://docs.airbyte.io/contributing-to-airbyte/building-new-connector#using-credentials-in-ci).
Expand All @@ -35,4 +36,3 @@ Expand the checklist which is relevant for this PR.
- [ ] Associated tickets have been closed & stakeholders notified
</p>
</details>

0 comments on commit 85425f8

Please sign in to comment.