make abstract

airbytehq · Feb 13, 2024 · 49b3692 · 49b3692
1 parent 10f0209
commit 49b3692
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/...s/src/main/java/io/airbyte/cdk/integrations/destination/jdbc/AbstractJdbcDestination.java b/...s/src/main/java/io/airbyte/cdk/integrations/destination/jdbc/AbstractJdbcDestination.java
@@ -250,11 +250,7 @@ private void assertCustomParametersDontOverwriteDefaultParameters(final Map<Stri
 
   protected abstract JdbcSqlGenerator getSqlGenerator();
 
-  protected JdbcDestinationHandler getDestinationHandler(final String databaseName, final JdbcDatabase database) {
-    // Pick a random dialect. Most destinations should override this anyway.
-    // TODO ... why can't we just make this method abstract?
-    return new JdbcDestinationHandler(databaseName, database, SQLDialect.POSTGRES);
-  }
+  protected abstract JdbcDestinationHandler getDestinationHandler(final String databaseName, final JdbcDatabase database);
 
   /**
    * "database" key at root of the config json, for any other variants in config, override this