Destination dev null: support dedup (#38118)

airbytehq · May 10, 2024 · 3525225 · 3525225
1 parent 09ad5e6
commit 3525225
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 4 deletions.
diff --git a/airbyte-integrations/connectors/destination-dev-null/metadata.yaml b/airbyte-integrations/connectors/destination-dev-null/metadata.yaml
@@ -2,7 +2,7 @@ data:
   connectorSubtype: file
   connectorType: destination
   definitionId: a7bcc9d8-13b3-4e49-b80d-d020b90045e3
-  dockerImageTag: 0.3.2
+  dockerImageTag: 0.3.3
   dockerRepository: airbyte/destination-dev-null
   githubIssueLabel: destination-dev-null
   icon: airbyte.svg

diff --git a/...n/java/io/airbyte/integrations/destination/dev_null/DevNullDestinationAcceptanceTest.java b/...n/java/io/airbyte/integrations/destination/dev_null/DevNullDestinationAcceptanceTest.java
@@ -14,6 +14,8 @@
 import java.util.Collections;
 import java.util.HashSet;
 import java.util.List;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
 
 public class DevNullDestinationAcceptanceTest extends DestinationAcceptanceTest {
 
@@ -59,8 +61,18 @@ protected void assertSameMessages(final List<AirbyteMessage> expected,
   }
 
   @Override
-  public void testSyncNotFailsWithNewFields() {
-    // Skip because `retrieveRecords` returns an empty list at all times.
+  // Skip because `retrieveRecords` returns an empty list at all times.
+  @Disabled
+  @Test
+  public void testSyncNotFailsWithNewFields() {}
+
+  @Override
+  // This test assumes that dedup support means normalization support.
+  // Override it to do nothing.
+  @Disabled
+  @Test
+  public void testIncrementalDedupeSync() throws Exception {
+    super.testIncrementalDedupeSync();
   }
 
 }
diff --git a/airbyte-integrations/connectors/destination-dev-null/src/test/resources/expected_spec.json b/airbyte-integrations/connectors/destination-dev-null/src/test/resources/expected_spec.json
@@ -3,7 +3,7 @@
   "supportsIncremental": true,
   "supportsNormalization": false,
   "supportsDBT": false,
-  "supported_destination_sync_modes": ["overwrite", "append"],
+  "supported_destination_sync_modes": ["overwrite", "append", "append_dedup"],
   "protocol_version": "0.2.1",
   "connectionSpecification": {
     "$schema": "http://json-schema.org/draft-07/schema#",

diff --git a/docs/integrations/destinations/dev-null.md b/docs/integrations/destinations/dev-null.md
@@ -6,6 +6,7 @@ The Airbyte `dev-null` Destination. This destination is for testing and debuggin
 
 | Version | Date       | Pull Request                                             | Subject           |
 | :------ | :--------- | :------------------------------------------------------- | :---------------- |
+| 0.3.3   | 2023-05-08 | [38118](https://github.com/airbytehq/airbyte/pull/38118) | Support dedup     |
 | 0.3.2   | 2023-05-08 | [25776](https://github.com/airbytehq/airbyte/pull/25776) | Support Refreshes |
 | 0.3.0   | 2023-05-08 | [25776](https://github.com/airbytehq/airbyte/pull/25776) | Change Schema     |
 | 0.2.7   | 2022-08-08 | [13932](https://github.com/airbytehq/airbyte/pull/13932) | Bump version      |