Skip to content

Conversation

@dbgold17
Copy link
Contributor

@dbgold17 dbgold17 commented Oct 23, 2025

After several PRs to remove problematic CDK dependencies, update the Manifest Server to use Python 3.13

resolves: https://github.com/airbytehq/airbyte-internal-issues/issues/14878

Testing

  • I published a pre-release manifest-server image and referenced it here on my local airbyte-platform-internal repo. Then I built the platform with make dev.up.oss and verified I could use the Connector Builder.

Summary by CodeRabbit

  • Chores
    • Upgraded container runtime environment to Python 3.13.9 for improved stability and performance.
    • Added explicit image digest to ensure reproducible and verifiable deployments.

@github-actions
Copy link

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@dbgold17/update-manifest-server-to-python-3.13#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch dbgold17/update-manifest-server-to-python-3.13

Helpful Resources

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poetry-lock - Updates poetry.lock file
  • /test - Runs connector tests with the updated CDK
  • /poe build - Regenerate git-committed build artifacts, such as the pydantic models which are generated from the manifest JSON schema in YAML.
  • /poe <command> - Runs any poe command in the CDK environment

📝 Edit this welcome message.

@github-actions
Copy link

PyTest Results (Fast)

3 813 tests  ±0   3 801 ✅ ±0   6m 31s ⏱️ +3s
    1 suites ±0      12 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 9cd51bf. ± Comparison against base commit c0e506f.

@github-actions
Copy link

PyTest Results (Full)

3 816 tests  ±0   3 804 ✅ ±0   11m 22s ⏱️ +3s
    1 suites ±0      12 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 9cd51bf. ± Comparison against base commit c0e506f.

@dbgold17 dbgold17 requested a review from pedroslopez October 23, 2025 22:57
@dbgold17 dbgold17 marked this pull request as ready for review October 23, 2025 23:00
Copilot AI review requested due to automatic review settings October 23, 2025 23:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Manifest Server's Docker base image from Python 3.12 to Python 3.13.9, following the removal of problematic CDK dependencies in previous work.

Key Changes

  • Updated Python base image to version 3.13.9 with pinned digest for reproducible builds

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 23, 2025

📝 Walkthrough

Walkthrough

The Dockerfile for the manifest_server base image was updated from Python 3.12 to Python 3.13.9 with an explicit sha256 digest for reproducible builds. All other build configuration steps remain functionally unchanged.

Changes

Cohort / File(s) Summary
Base image update
airbyte_cdk/manifest_server/Dockerfile
Updated Python base image from python:3.12-slim-bookworm to python:3.13.9-slim-bookworm with explicit sha256 digest for build reproducibility.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

chore

Suggested reviewers

  • aaronsteers

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "chore: update Manifest Server to use Python 3.13" directly and accurately describes the main change in the changeset. The Dockerfile base image was updated from Python 3.12 to Python 3.13, which is exactly what the title communicates. The title is concise, specific, uses a conventional "chore:" prefix for maintenance work, and avoids vague language or noise. A teammate scanning the commit history would immediately understand that this is a Python version upgrade for the Manifest Server.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dbgold17/update-manifest-server-to-python-3.13

Comment @coderabbitai help to get the list of available commands and usage tips.

@dbgold17 dbgold17 changed the title Update Manifest Server to use Python 3.13 chore: update Manifest Server to use Python 3.13 Oct 23, 2025
Copy link
Contributor

@pedroslopez pedroslopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dbgold17 dbgold17 merged commit 26a9b98 into main Oct 23, 2025
36 of 39 checks passed
@dbgold17 dbgold17 deleted the dbgold17/update-manifest-server-to-python-3.13 branch October 23, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants