feat(low-code): camel_case_to_snake_case macros #617
Conversation
|
/autofix
|
darynaishchenko
changed the title
📝 WalkthroughWalkthroughA new macro function, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant MacroSystem
participant camel_case_to_snake_case
User->>MacroSystem: Request interpolation with camel case input
MacroSystem->>camel_case_to_snake_case: Call macro with input string
camel_case_to_snake_case-->>MacroSystem: Return snake_case string
MacroSystem-->>User: Provide interpolated result
Would you like to see additional test scenarios for edge cases in the macro, such as handling numbers or special characters, wdyt? 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
airbyte_cdk/sources/declarative/interpolation/macros.py(3 hunks)unit_tests/sources/declarative/interpolation/test_macros.py(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: ChristoGrab
PR: airbytehq/airbyte-python-cdk#58
File: airbyte_cdk/sources/declarative/yaml_declarative_source.py:0-0
Timestamp: 2024-11-18T23:40:06.391Z
Learning: When modifying the `YamlDeclarativeSource` class in `airbyte_cdk/sources/declarative/yaml_declarative_source.py`, avoid introducing breaking changes like altering method signatures within the scope of unrelated PRs. Such changes should be addressed separately to minimize impact on existing implementations.
Learnt from: aaronsteers
PR: airbytehq/airbyte-python-cdk#13
File: airbyte_cdk/connector.py:99-99
Timestamp: 2024-11-10T04:50:11.914Z
Learning: When a PR's goal is to run the autoformat task from `ruff`, avoid suggesting code changes beyond formatting to prevent potential negative side effects.
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: Check: source-amplitude
- GitHub Check: Check: source-hardcoded-records
- GitHub Check: Check: source-intercom
- GitHub Check: Check: source-shopify
- GitHub Check: Pytest (Fast)
- GitHub Check: Pytest (All, Python 3.11, Ubuntu)
- GitHub Check: Pytest (All, Python 3.10, Ubuntu)
- GitHub Check: SDM Docker Image Build
🔇 Additional comments (2)
airbyte_cdk/sources/declarative/interpolation/macros.py (2)
7-7: LGTM!The
reimport is correctly placed and necessary for the new macro function.
214-214: Update the reference after fixing the function name.This addition to the macros list is correct! Just remember to update the function name reference here too when you fix the typo above, wdyt?
- camel_cate_to_snake_case, + camel_case_to_snake_case,
darynaishchenko
changed the title
|
/autofix
|
Add
camel_case_to_snake_caseto transform values from CamelCase to snake_caseNeeded for bing-ads custom reports to transform custom report names.
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Tests