-
Notifications
You must be signed in to change notification settings - Fork 24
ci: auto-publish sdm for each release #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
What do you think about these suggestions? Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/workflows/pypi_publish.yml (1)
Line range hint
201-211
: How about enhancing the version check robustness? wdyt?The version check in the
publish_sdm
job could be more descriptive and handle edge cases better. Here's a suggestion:- name: "Check for existing tag (version: ${{ env.VERSION || 'none' }} )" if: env.VERSION != '' run: | tag="airbyte/source-declarative-manifest:${{ env.VERSION }}" - if [ -z "$tag" ]; then + if [ -z "${{ env.VERSION }}" ]; then echo "Error: VERSION is not set. Ensure the tag follows the format 'refs/tags/vX.Y.Z'." exit 1 fi echo "Checking if tag '$tag' exists on DockerHub..." if DOCKER_CLI_EXPERIMENTAL=enabled docker manifest inspect "$tag" > /dev/null 2>&1; then - echo "The tag '$tag' already exists on DockerHub. Skipping publish to prevent overwrite." + echo "Error: The tag '$tag' already exists on DockerHub." + echo "To prevent accidental overwrites, please:" + echo "1. Ensure you're publishing a new version" + echo "2. Delete the existing tag if you really need to republish" exit 1 fiThe changes:
- Check
VERSION
directly instead of the constructed tag- Provide more actionable error messages
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/pypi_publish.yml
(1 hunks)
🔇 Additional comments (1)
.github/workflows/pypi_publish.yml (1)
154-155
: LGTM! The job conditions look well-structured.
The updated conditions for publish_sdm
nicely handle both automated (push events with version tags) and manual triggers. This aligns perfectly with the workflow's purpose of flexible publishing control.
Originally I had wanted to wait for:
--use-local-cdk
or similar) #64This PR enables auto-release anyway, on the basis that if Builder adopts the CDK version before Platform does, it also creates an outage.