Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the ability list and restart deployments #93

Merged
merged 7 commits into from
Aug 30, 2024

Conversation

colesnodgrass
Copy link
Member

  • fix https://github.com/airbytehq/airbyte-internal-issues/issues/9582
  • add a abctl local deployments sub command
    • by default will list all the deployments
    • if passed --restart=[deployment name], will restart the provided deployment
  • add k8stest package
    • moved mockK8Client (from the existing tests) to MockClient in this package
    • follows a similar model that the package dockertest uses
  • update the default k8s.Client to be injectable (in kong)
    • this enabled me to write tests for the deployment sub-command
    • also adds the ability to write tests easier for other sub-commands (not in this PR)

@colesnodgrass colesnodgrass requested a review from a team as a code owner August 29, 2024 21:36
internal/cmd/local/k8s/client.go Outdated Show resolved Hide resolved
internal/cmd/local/k8s/client.go Outdated Show resolved Hide resolved
colesnodgrass and others added 3 commits August 30, 2024 10:30
Co-authored-by: Alex Buchanan <alex.buchanan@airbyte.io>
@colesnodgrass colesnodgrass merged commit bedbead into main Aug 30, 2024
2 checks passed
@colesnodgrass colesnodgrass deleted the cole/restart-service branch August 30, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants