refactor: break main into functions #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal/update/update.go
Outdated
| @@ -20,7 +22,13 @@ type doer interface { | |||
| // This is accomplished by fetching the latest github tag and comparing it to the version provided. | |||
| // Returns the latest version, or an empty string if we're already running the latest version. | |||
| // Will return ErrDevVersion if the build.Version is currently set to "dev". | |||
| func Check(ctx context.Context, doer doer, version string) (string, error) { | |||
| func Check() (string, error) { | |||
There was a problem hiding this comment.
This should still accept an external context.Context. The reason being we want to be able to cancel all the contexts by canceling the one root context.
There was a problem hiding this comment.
By the time you cancel the parent context in the CLI, the code has called os.Exit already.
But, I could still pipe it through if you think it's important.
There was a problem hiding this comment.
I think it's still worth doing.
abuchanan-airbyte
force-pushed
the
abuch/update-refactor
branch
from
8c7e00d
to
153400a
Compare
colesnodgrass
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just chipping away at some minor code cleanup.