Code

Add GDALViewshedGenerate binding#142

Code

Merged

tbonfort merged 34 commits intoairbusgeo:mainairbusgeo/godal:mainfrom Arlula:viewshedArlula/godal:viewshedCopy head branch name to clipboardFeb 15, 2025

Commits

Commits on Jan 22, 2025

• Implement `GDALViewshedGenerate` binding

  pericles-tpt

  committed
  9c97962

  Copy full SHA for 9c97962

• Implement `Viewshed` go function

  pericles-tpt

  committed
  f43b9a5

  Copy full SHA for f43b9a5

• Add first Viewshed test (not working yet)

  pericles-tpt

  committed
  f14b181

  Copy full SHA for f14b181

Commits on Jan 25, 2025

• Replace `TestViewshedAllVisible` with more comprehensive `TestViewshedSimpleHeight`

  pericles-tpt

  committed
  6baaabe

  Copy full SHA for 6baaabe

• Add missing documentation comments

  pericles-tpt

  committed
  cb15f6d

  Copy full SHA for cb15f6d

• Temporarily enable "github workflows" for `viewshed` branch

  pericles-tpt

  committed
  c41d8a2

  Copy full SHA for c41d8a2

• Add check to viewshed test to ensure 'scope 2' only runs when GDAL version > 3.10

  pericles-tpt

  committed
  6ec4f2e

  Copy full SHA for 6ec4f2e

• Only allow 'dem' height mode in go binding function when GDAL version > 3.10 (not sure about this approach...)

  pericles-tpt

  committed
  b3facee

  Copy full SHA for b3facee

• Add preprocessor check ensuring `GDALViewshedGenerate` only runs with compatible GDAL versions

  pericles-tpt

  committed
  8242bc7

  Copy full SHA for 8242bc7

• Fix incorrect `godalViewshed` function naming

  pericles-tpt

  committed
  ab287ff

  Copy full SHA for ab287ff

• Add checks to `Viewshed` for conditions where `godalViewshedGenerate` WILL run, but produces invalid test results

  pericles-tpt

  committed
  b796ab8

  Copy full SHA for b796ab8

• Add error to `Viewshed()` for the "unsupported GDAL version" condition

  pericles-tpt

  committed
  b8f67d8

  Copy full SHA for b8f67d8

• Add checks for "invalid GDAL version" errors to `TestViewshedSimpleHeight`

  pericles-tpt

  committed
  f8d0dd0

  Copy full SHA for f8d0dd0

• Fix `godalViewshedGenerate` using unsupported enums for GDAL < 3.1.0

  pericles-tpt

  committed
  d3d1718

  Copy full SHA for d3d1718

• Fix late error for "GDAL version < 3.1.0" condition

  pericles-tpt

  committed
  2148307

  Copy full SHA for 2148307

• Disable "github workflows" for `viewshed` branch

  pericles-tpt

  committed
  0c11cfb

  Copy full SHA for 0c11cfb

Commits on Jan 28, 2025

• Move `forceError()` out of `#if` block

  pericles-tpt

  committed
  862bbeb

  Copy full SHA for 862bbeb

• Use `ErrorHandler` on all branches of `TestViewshedSimpleHeight`

  pericles-tpt

  committed
  cb219cc

  Copy full SHA for cb219cc

• Add `TestViewshedCreationOptions` to test valid/invalid creation options

  pericles-tpt

  committed
  82f2df3

  Copy full SHA for 82f2df3

• Maybe fix 'scanline size' error and add "CreationOptions + ErrLogger" case in `TestViewshedCreationOptions`

  pericles-tpt

  committed
  14c242c

  Copy full SHA for 14c242c

• Minor change

  pericles-tpt

  committed
  b6ff5fd

  Copy full SHA for b6ff5fd

• Add missing "min version" checks to `TestViewshedCreationOptions`

  pericles-tpt

  committed
  9f67065

  Copy full SHA for 9f67065

• Remove `ErrLogger` from `ViewShed()` call where it's not used

  pericles-tpt

  committed
  f67b649

  Copy full SHA for f67b649

Commits on Feb 11, 2025

• Add error for "minimum GDAL version for viewshed" check

  Show description for 5a79c47
  

  pericles-tpt

  and

  tbonfort

  authored
  5a79c47

  Copy full SHA for 5a79c47

• Remove GDAL version checks for < 3.4.2

  Show description for 062d772
  

  pericles-tpt

  and

  tbonfort

  authored
  062d772

  Copy full SHA for 062d772

• Remove GDAL version checks for < 3.4.2 (in tests)

  Show description for c57f4d1
  

  pericles-tpt

  and

  tbonfort

  authored
  c57f4d1

  Copy full SHA for c57f4d1

• Replace "min version" checks in `Viewshed()` with a comment documenting test behaviour

  pericles-tpt

  committed
  f1b37dd

  Copy full SHA for f1b37dd

• Remove assert for error that was removed

  pericles-tpt

  committed
  eab0388

  Copy full SHA for eab0388

Commits on Feb 12, 2025

• Add checks for tests that fail when GDAL version < 3.4.2, add back error check for version < 3.1.0

  pericles-tpt

  committed
  536a9e6

  Copy full SHA for 536a9e6

• Add GDAL version < 3.1.0 check to `TestViewshedCreationOptions`

  pericles-tpt

  committed
  223ebd5

  Copy full SHA for 223ebd5

• Change `Viewshed()` to a method on `Band()` and convert most of its parameters to options

  pericles-tpt

  committed
  46da29d

  Copy full SHA for 46da29d

• Remove "min version 3.1.0" checks

  pericles-tpt

  committed
  5e8164e

  Copy full SHA for 5e8164e

Commits on Feb 15, 2025

• Add missing `Close()` calls for datasets in Viewshed tests

  pericles-tpt

  committed
  f38e1df

  Copy full SHA for f38e1df

• Add list of available `ViewshedOption`s to `Viewshed` documentation comment

  pericles-tpt

  committed
  8f9c622

  Copy full SHA for 8f9c622