Compatibility with python2.4 was broken

.github/workflows/portability.yml

@@ -86,9 +86,14 @@ jobs:
         cd Python-2.4.6
         ./configure
         make
-        export PATH=$(pwd):$PATH
-        cd ../cpu_rec
+        sudo ln -fs $(pwd)/python /usr/local/bin/python
+    - name: Test python version
+      run: |
         python -c 'import sys;print(sys.version)'
+        python -V
+    - name: Uncompress corpus (no lzma module in python2.4)
+      run: |
+        unxz cpu_rec_corpus/*.xz
     - name: Analyze /bin/sh
       run: |
         python ./cpu_rec.py -v /bin/sh

cpu_rec.py

@@ -282,8 +282,11 @@ def extract_section_lief(data, section=None):
         l = lief.parse(data)
         if not l:
             return data
-        res = b""
-        section_names = [section] if section else [".text", "__TEXT"]
+        res = struct.pack("")
+        if section:
+            section_names = [section]
+        else:
+            section_names = [".text", "__TEXT"]
         for s in l.sections:
             if s.name in section_names:
                 res += s.content