[axis] add AxisRadial component
#404
Conversation
| .map((val, index) => { | ||
| if (hideZero && val === 0) return null; | ||
|
|
||
| const angle = scale(val) - Math.PI / 2; |
There was a problem hiding this comment.
Maybe haven't had enough ☕️ but I don't fully understand why the -🥧/2 is needed ... but with different scale ranges (e.g., [-🥧, 🥧], [0, 2*🥧]), the axis was always rotated +45° without this.
| const dy = toPoint.y - fromPoint.y; | ||
|
|
||
| // offset the label in the same direction as the tick orientation | ||
| const x = toPoint.x + dx / 2; |
There was a problem hiding this comment.
this offset is somewhat arbitrary but gave decent results as you can see in the demo tile. we could possibly make it more configurable.
|
|
||
| if (children) { | ||
| return ( | ||
| <Group className={cx('vx-axis-radial', axisClassName)} top={top} left={left}> |
There was a problem hiding this comment.
all classes are the same as other Axis* components except this top-level one, which should be sufficient to distinguish from other (linear) axes on the page.
| stroke={stroke} | ||
| strokeWidth={strokeWidth} | ||
| strokeDasharray={strokeDasharray} | ||
| curve={curveCardinal} |
There was a problem hiding this comment.
does this always have to be curveCardinal? should it be configurable via prop?
There was a problem hiding this comment.
I think you'd probably want this most of the time, otherwise the axis wouldn't look like an arc.
In thinking about this more though, I changed the implementation of GridRadial to use Arc instead of LineRadial, that could simplify this as well and allow us to drop the @vx/curve dep. With LineRadial we're sort of doing the arc interpolation ourself but Arc should be best at that.
|
@williaster this looks great! Where did this PR get to? This is exactly what I'm after in order to create some gauge-style components. Is there some way I can help in order to get this merged? Edit: |
|
hey @MrBlenny 👋 the gauge looks great! 😍 This PR was never completed/I lost bandwidth to get it merged. @sarathps93 implemented the |
| if (labelOrientation === 'top') { | ||
| y = -radius - offset; | ||
| } else if (labelOrientation === 'right') { | ||
| x = radius + offset; | ||
| textAnchor = 'start'; | ||
| } else if (labelOrientation === 'bottom') { | ||
| y = radius + offset; | ||
| } else if (labelOrientation === 'left') { | ||
| x = -radius - offset; | ||
| textAnchor = 'end'; | ||
| } |
4 participants
🚀 Enhancements
This PR
<AxisRadial />component to the@vx/axispackagepropTypedescriptions and tests for<AxisRadial />LineRadialdemo tile to also include the<AxisRadial />component: