Add rule to prefer count(where: { ... }) over filter { ... }.count
#295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
commented
Dec 9, 2024
calda
force-pushed
the
cal--preferCountWhere
branch
from
f60fa7d to
3371c2f
Compare
|
LGTM |
calda
force-pushed
the
cal--preferCountWhere
branch
from
3371c2f to
2dd922e
Compare
calda
force-pushed
the
cal--preferCountWhere
branch
from
2dd922e to
849c8ad
Compare
bachand
reviewed
Dec 13, 2024
| let planetsWithMoons = planets.filter { !$0.moons.isEmpty }.count | ||
|
|
||
| // RIGHT | ||
| let planetsWithMoons = planets.count(where: { !$0.moons.isEmpty }) |
There was a problem hiding this comment.
Nice! I imagine that this must be more efficient, especially with large collections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR proposes a new rule to prefer using
count(where: { ... })overfilter { ... }.count.Autocorrect is implemented in nicklockwood/SwiftFormat#1939.
Reasoning
Swift 6.0 (finally!) added a
count(where:)method to the standard library.