Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sc rules update #211

Closed
wants to merge 40 commits into from
Closed
Changes from 2 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
c6593c7
Slumber Group modifications to AirBnB SwiftLint
waroo Apr 7, 2021
cde370e
Merge pull request #1 from waroo/patch-1
waroo Apr 7, 2021
ebd05f9
Merge upstream branch
kitefaster Jun 23, 2021
aa59395
Merge branch 'airbnb-master'
kitefaster Jun 23, 2021
97fd899
Update README.md
waroo Aug 24, 2021
289fdda
Update README.md
waroo Aug 24, 2021
be7d355
Create xcode_settings_slumber_group.bash
waroo Aug 24, 2021
962e385
Update swiftlint.yml
waroo Aug 24, 2021
14d5886
Update swiftlint.yml
waroo Aug 24, 2021
d20e38f
Update swiftlint.yml
waroo Aug 26, 2021
960c4b6
Update swiftlint.yml
waroo Aug 26, 2021
26c7e0d
Merge branch 'airbnb:master' into master
waroo Sep 29, 2021
5b2f3d0
Merge branch 'airbnb:master' into master
waroo Nov 1, 2021
be2771c
Merge branch 'master' of https://github.com/airbnb/swift
kitefaster Feb 9, 2022
db32576
Update swiftlint.yml
waroo Feb 15, 2022
3baa839
Update swiftlint.yml
waroo Feb 15, 2022
2bd00fb
Update swiftlint.yml
waroo Feb 15, 2022
e70268f
Update swiftlint.yml
waroo Feb 15, 2022
7dafe9f
Update swiftlint.yml
waroo Feb 15, 2022
c327bfe
Fix, moved rules configuration above custom rules, to make it less co…
standinga Feb 15, 2022
1aac28f
Merge pull request #4 from slumberGroup/feature/fix-rules
waroo Feb 16, 2022
305641c
Removed listing rules already handled in custom_rules section
standinga Feb 17, 2022
d208b63
Merge pull request #5 from slumberGroup/feature/cleanup-rules
waroo Feb 17, 2022
098aa6f
Merge branch 'airbnb:master' into master
waroo Feb 18, 2022
a3789cb
Update swiftlint.yml
waroo Feb 18, 2022
c7203e3
Update airbnb.swiftformat
waroo Mar 3, 2022
441953b
Update airbnb.swiftformat
Apr 20, 2022
ed8b04a
Update README.md
Apr 20, 2022
63711bc
Update README.md with examples for the new rules
Apr 20, 2022
77f8fcd
Remove wrapMultilineStatementBraces that is now the default behavior …
Apr 21, 2022
62491ac
Fix README.md amendment format + update to the new 130 max column wid…
Apr 21, 2022
bc8a11e
Merge pull request #6 from slumberGroup/add-missing-rule-and-own-rules
Apr 22, 2022
ed932ca
Merge branch 'airbnb:master' into master
waroo May 18, 2022
ab27c7b
Merge branch 'airbnb:master' into master
waroo May 27, 2022
2ab2bf6
Fix redundantRawValues code example
waroo Jun 29, 2022
7c77f88
Squashed commit of the following:
Halle Dec 6, 2022
901b21d
Required adjustments to ruleset
Halle Dec 6, 2022
700ef91
Merge branch 'pullrequests/airbnb/master'
Halle Dec 21, 2022
7b7425f
Merge pull request #9 from airbnb/master
waroo Jan 12, 2023
5dfa1c0
Removed our override of the general attributes rule
Halle Jan 16, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions resources/swiftlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,41 +42,43 @@ custom_rules:
regex: "@objcMembers"
message: "Explicitly use @objc on each member you want to expose to Objective-C"
severity: error
no_direct_standard_out_logs:
name: "Writing log messages directly to standard out is disallowed"
regex: "(\\bprint|\\bdebugPrint|\\bdump|Swift\\.print|Swift\\.debugPrint|Swift\\.dump)\\s*\\("
match_kinds:
- identifier
message: "Don't commit `print(…)`, `debugPrint(…)`, or `dump(…)` as they write to standard out in release. Either log to a dedicated logging system or silence this warning in debug-only scenarios explicitly using `// swiftlint:disable:next no_direct_standard_out_logs`"
severity: warning

colon:
apply_to_dictionaries: false
colon:
apply_to_dictionaries: false

line_length:
line_length:
warning: 400
error: 500
ignores_function_declarations: true
ignores_comments: true
ignores_urls: true

function_body_length:
function_body_length:
warning: 300
error: 500

function_parameter_count:
function_parameter_count:
warning: 6
error: 8

type_body_length:
type_body_length:
warning: 300
error: 500

file_length:
file_length:
warning: 1000
error: 1500
ignore_comment_only_lines: true

cyclomatic_complexity:
cyclomatic_complexity:
warning: 25
error: 25

type_name:
max_length:
warning: 60
type_name:
max_length:
warning: 60

attributes:
always_on_line_above: ["@testable", "@available", "@discardableResult", "@objc", "@IBAction", "@IBDesignable"]
attributes:
always_on_line_above: ["@testable", "@available", "@discardableResult", "@objc", "@IBAction", "@IBDesignable"]