Improve CONTRIBUTING guidelines to require forks #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bachand
approved these changes
Sep 13, 2018
CONTRIBUTING.md
Outdated
|
|
||
| If you have an idea that's not completely fleshed out, please open an issue to discuss. | ||
| If you have an idea that's not completely fleshed out, please open [an issue](https://github.com/airbnb/swift/issues/new) to discuss. |
There was a problem hiding this comment.
Since the link creates an issue what if we have all of open an issue be a link instead of just an issue?
|
Merging since this was already discussed and agreed 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Clarify the need to require forks for new proposals.
Reasoning
We'll be following open source standards (and following our Javascript Style Guide) and require forks for everybody contributing to repo instead of doing PRs directly.
Reviewers
cc @airbnb/swift-styleguide-maintainers