Skip to content

Memoize WithStylesContextProvider value #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Memoize WithStylesContextProvider value #236

wants to merge 1 commit into from

Conversation

yepitschunked
Copy link

Avoids re-rendering of context consumers whenever the provider re-renders.

ljharb
ljharb approved these changes Jan 15, 2020
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’d be good to have some tests if possible, but these things can be tough to test.

@ljharb ljharb requested review from ahuth and lencioni January 15, 2020 02:41
@lencioni lencioni requested a review from noratarano January 15, 2020 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@noratarano noratarano Awaiting requested review from noratarano

Assignees
No one assigned
Labels
semver-patch: fixes etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yepitschunked @ljharb