Fix gc stats race condition and add timestamp of the gc run #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, our counters on the number of GC runs were being read from a static struct when constructing the stats event to emit. In blocks of synchronous code, GC can run multiple times before control returns to the event loop where the stats events will be constructed and emitted. All events would then get the same values for the counters at the time the events are created. This passes a copy of the counters with the baton to fix this. This also adds a us timestamp of when the gc run occurred, which can be useful for sequencing events.
martinwin
approved these changes
May 22, 2018
Collaborator
martinwin
left a comment
martinwin
left a comment
There was a problem hiding this comment.
Man, it's been a long time since I've written C code.
|
Hi @schleyfox , Is there really a need of gettimeofday() because sys/time.h doesn't exist on windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, our counters on the number of GC runs were being read from a
static struct when constructing the stats event to emit. In blocks of
synchronous code, GC can run multiple times before control returns to
the event loop where the stats events will be constructed and emitted.
All events would then get the same values for the counters at the time
the events are created. This passes a copy of the counters with the
baton to fix this.
This also adds a us timestamp of when the gc run occurred, which can be
useful for sequencing events.
/cc @goatslacker @martinwin