Thread haproxy_server_options through from reporters #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option can be used to enable custom server level options in the fronting haproxy instances, which allows things like declaring that a particular node is a backup or should be healthchecked a special way.
|
I can confirm this is passing options to Zookeper successfully. One note though - if the config is changed to include those additional options and then a Nerve restart is done, a new node is created in Zookeeper, but the old ephemeral node does not disappear until manually removed. |
Collaborator
Author
|
@Jaykah I'm going to merge this because I can't reproduce that bug. Which version of ruby, nerve, and zookeeper are you using? Are you sure that the old nerve process is no longer running? @zhitaoli I can merge this now but I can't really get it into production to verify for at least a week (thanksgiving). |
jolynch
added a commit
that referenced
this pull request
Nov 25, 2015
Thread haproxy_server_options through from reporters
|
@jolynch Awesome! Many thanks for the progress! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option can be used to enable custom server level options in the
fronting haproxy instances, which allows things like declaring that a
particular node is a backup or should be healthchecked a special way.
Synapse already partially supports this option and it will have full support once airbnb/synapse#144 is merged.