fix: canvas text empty shapes #3042
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harperKKK
force-pushed
the
fix-canvas-empty-shape
branch
from
6c1ac57
to
4b31178
Compare
|
not sure what youre asking. it loads as a black rectangle so i dont knw if that is what its supposed to be or not. is that the render frame error you refer to? there is a few Kanji characters in there that might be causing issues if its having trouble parsing the file? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix canvas render error when "\r" occur in text
TypeError: Cannot read properties of undefined (reading 'it')
at CVTextElement.buildNewText (http://127.0.0.1:5500/build/player/lottie.js:13949:55)
at ITextElement.validateText (http://127.0.0.1:5500/build/player/lottie.js:11977:12)
at CVTextElement.renderInnerContent (http://127.0.0.1:5500/build/player/lottie.js:13998:10)
at CVTextElement.renderFrame (http://127.0.0.1:5500/build/player/lottie.js:13262:12)
at CanvasRendererBase.renderFrame (http://127.0.0.1:5500/build/player/lottie.js:14459:28)
at AnimationItem.renderFrame (http://127.0.0.1:5500/build/player/lottie.js:2059:21)
at AnimationItem.gotoFrame (http://127.0.0.1:5500/build/player/lottie.js:2045:10)
at AnimationItem.checkLoaded (http://127.0.0.1:5500/build/player/lottie.js:2016:12)
at AnimationItem.waitForFontsLoaded (http://127.0.0.1:5500/build/player/lottie.js:1997:12)
at AnimationItem.configAnimation (http://127.0.0.1:5500/build/player/lottie.js:1981:12)