Favor stateless functions over classes when there's no state #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // good | ||
| function Listing({ hello }){ |
There was a problem hiding this comment.
there should always be a space between ) and {
ljharb
changed the title
|
Thanks, this looks great pending a few comments. It would be ideal if there was a linter rule that could help enforce this, although it may not be possible. |
According to PR comments.
| @@ -5,7 +5,7 @@ | |||
| ## Table of Contents | |||
|
|
|||
| 1. [Basic Rules](#basic-rules) | |||
| 1. [Class vs `React.createClass`](#class-vs-reactcreateclass) | |||
| 1. [Class vs `React.createClass` vs stateless](#class-vs-reactcreateclass-vs-stateless) | |||
There was a problem hiding this comment.
it's unfortunate that this will break the link - however since the title on line 28 didn't change, are you sure this link works now?
- Space between function name and args;
- use `render(){}` syntax in object literal;
- Fix link to section;
|
It's all fixed. |
ljharb
added a commit
that referenced
this pull request
Jan 21, 2016
[guide] Favor stateless functions over classes when there's no state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.