Prohibit Padded Blocks and Allow Comments in the First Line of a Block #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses airbnb#483
In airbnb#483, justjake said that we should update the style guide to allow single line comments in the first line of a block.
banhathome
changed the title
Collaborator
There was a problem hiding this comment.
It would be nice to show one of these examples as an if...else
Contributor
Author
There was a problem hiding this comment.
Sure thing! I just made my change; let me know what you think!
Collaborator
|
Nice! Thanks for the PR |
justjake
added a commit
that referenced
this pull request
Nov 6, 2015
Prohibit Padded Blocks and Allow Comments in the First Line of a Block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #483, @justjake says that we should amend the style guide to allow single line comments in the first line of a block. I updated 17.2 with this change.
In addition, our ESLint config file prohibits padded blocks, so I decided to make a section 18.8 to address that.