React/JSX Style Guide - #331
Merged
Merged
Conversation
Contributor
|
😁 👍 |
Collaborator
|
👍 |
Member
There was a problem hiding this comment.
I'm not sold on the /> goes to new line. I know the benefit is the same as the additional trailing comma, but it adds noising lines that make scanning a render call harder. So the tradeoff is easier to read vs. nice git diffs.
There was a problem hiding this comment.
yeah, closing angles on new lines look really bad
Member
There was a problem hiding this comment.
Not a blocker for merging. I'll follow up in a separate issue.
…, added camelCase for props
Contributor
Author
|
Thanks everyone for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets share our internal React/JSX style guide!
@hshoff @goatslacker @spikebrehm