Code made compatible with Airbnb style guide#2806
Draft
0o001 wants to merge 4 commits intoairbnb:masterfrom
Draft
Code made compatible with Airbnb style guide#28060o001 wants to merge 4 commits intoairbnb:masterfrom
0o001 wants to merge 4 commits intoairbnb:masterfrom
Conversation
https://github.com/airbnb/javascript#destructuring--array And severities array put inside the getSeverity function
ljharb
requested changes
Aug 7, 2023
Collaborator
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
What is enforcing this change?
Contributor
Author
I wanted to align the used codes with the format recommended in Airbnb's own style guide. |
Collaborator
|
Right, but our own eslint rules in this project should be enforcing that, rather than doing it manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add arrays bracket newline
https://github.com/airbnb/javascript#arrays--bracket-newline
Add array destructuring
https://github.com/airbnb/javascript#destructuring--array
And severities array put inside the getSeverity function