Remove invalid name - Naming Conventions #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In naming conventions `var this-is-my-object = {};` is given as an example of a bad name. But since this is an invalid name in Javascript. I dont think it is needed since its a syntax error.
|
+1 |
|
Good catch! 🍻 |
hshoff
added a commit
that referenced
this pull request
Nov 18, 2013
Remove invalid name - Naming Conventions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In naming conventions
var this-is-my-object = {};is given as an example of a bad name. But this is an invalid name in Javascript. I dont think it is needed since its a syntax error and an invalid name in the first place.