Added setTouchEnabled to disable zoom, pan and drag. #41
Conversation
|
My use case was that we display a map of marker(s) but we don't allow the user to move the map. I think it's common enough of a use case that the Google v2 maps also support which is why I added the PR to include it in. Let me know if you have any questions? Best Tommy |
| @@ -1,3 +1,6 @@ | |||
| # 1.1.6 | |||
| * Added setTouchEnabled() to enable/disable zoom, pan and drag | |||
There was a problem hiding this comment.
you can leave this part out -- we'll include it once we push an updated version to maven central, which may include additional changes
|
@ericlevine thanks I'll make those changes. |
tomafc330
force-pushed
the
master
branch
2 times, most recently
from
faa8279
to
ee181a6
Compare
| return airMapInterface; | ||
| } | ||
|
|
||
| // case where it's not a native map, doesn't use AirGoogleMapOptions |
There was a problem hiding this comment.
@petzel I'm having a little bit of trouble with using the options for the NATIVE type -- it won't accept an instance of AirGoogleMapOptions (it takes an AirMapType).
Therefore I proceeded to using the code below. However, the OnMapLoadedListener gets overridden by this activity's onMapInitialized method. Is there a way for me to overcome this? Thanks
There was a problem hiding this comment.
should we instead place this setter into the builder, so we don't have to wait until initialization to set touch enabled/disabled?
There was a problem hiding this comment.
@petzel the type AirMapType doesn't have access to the underlying map. Any ideas?
There was a problem hiding this comment.
I feel like adding this functionality to the sample app in the menu isn't the best way to do it. We should probably create a separate configuration screen, from which users can tweak all of the available settings for any type of map.
If you remove the changes from the sample app, it looks good to merge, then I can integrate it into the sample app in a separate configuration screen.
|
Hey @tommytcchan, any plans to address the final comments so we can merge this? |
|
Hi Eric, Best Tommy On Thu, Mar 3, 2016 at 10:40 PM, Eric Petzel notifications@github.com
|
tomafc330
force-pushed
the
master
branch
2 times, most recently
from
0f372d3
to
11c1fe5
Compare
|
@petzel Updated the code after rebasing from origin/master -- also removed from the menu and sample app. Did test to make sure the new feature was working for both native and webmaps. |
|
@petzel Let me know what you think thanks |
|
@petzel TTT |
|
@tommytcchan, @petzel can we fix the conflicts to merge this? I would like to use this method. |
|
@petzel I can fix the conflicts if there is an intent to merge this in. Thanks |
|
Any update on this? This is needed for our use case as well |
Added example usage as well as update release notes