Skip to content

Init repo; inference code #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 29, 2024
Merged

Init repo; inference code #1

merged 17 commits into from
Sep 29, 2024

Conversation

AvivNavon
Copy link
Collaborator

No description provided.

@AvivNavon AvivNavon requested review from AvivSham and gil56 September 24, 2024 19:39
AvivSham
AvivSham reviewed Sep 25, 2024
View reviewed changes
AvivSham
AvivSham reviewed Sep 25, 2024
View reviewed changes
AvivSham
AvivSham reviewed Sep 25, 2024
View reviewed changes
AvivSham
AvivSham reviewed Sep 25, 2024
View reviewed changes
AvivSham
AvivSham reviewed Sep 25, 2024
View reviewed changes
AvivSham
AvivSham requested changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@AvivSham AvivSham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See minor inline comments.

AvivNavon and others added 3 commits September 25, 2024 09:28
@AvivNavon @AvivSham
Update setup.py
6a4d435 
Co-authored-by: Aviv Shamsian <Mista2311@gmail.com>
@AvivNavon @AvivSham
Update setup.py
b6f77a5 
Co-authored-by: Aviv Shamsian <Mista2311@gmail.com>
@AvivNavon
formatting; remove unused utils
338f13e
AvivSham
AvivSham reviewed Sep 25, 2024
View reviewed changes
@AvivNavon
Copy link
Collaborator Author

@AvivSham please take a look once again

@AvivNavon AvivNavon requested a review from AvivSham September 29, 2024 08:44
AvivSham
AvivSham reviewed Sep 29, 2024
View reviewed changes
@AvivSham AvivSham self-requested a review September 29, 2024 09:24
AvivSham
AvivSham approved these changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@AvivSham AvivSham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. See README comment we should include specific note regarding Vox's licence

AvivNavon and others added 2 commits September 29, 2024 12:50
@AvivNavon @AvivSham
Update README.md
e77c5dd 
Co-authored-by: Aviv Shamsian <Mista2311@gmail.com>
@AvivNavon
minor
434a697
@AvivNavon AvivNavon merged commit 8be6ec9 into main Sep 29, 2024
@AvivNavon AvivNavon deleted the init-setup branch October 6, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AvivSham AvivSham AvivSham approved these changes

@gil56 gil56 gil56 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AvivNavon @AvivSham @gil56