Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move URL parsing functions to their own module #1360

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Move URL parsing functions to their own module #1360

merged 1 commit into from
Oct 21, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 21, 2024

This is an internal change only

This is an internal change only
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Oct 21, 2024
Copy link

codspeed-hq bot commented Oct 21, 2024

CodSpeed Performance Report

Merging #1360 will not alter performance

Comparing parse_module (b5723dc) with master (cb24592)

Summary

✅ 83 untouched benchmarks

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.16%. Comparing base (cb24592) to head (b5723dc).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1360   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files          29       30    +1     
  Lines        5581     5587    +6     
  Branches      346      346           
=======================================
+ Hits         5367     5373    +6     
  Misses        188      188           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 96.16% <100.00%> (+<0.01%) ⬆️
MyPy 45.45% <100.00%> (+0.06%) ⬆️
OS-Linux 99.34% <99.28%> (+<0.01%) ⬆️
OS-Windows 99.40% <99.28%> (+<0.01%) ⬆️
OS-macOS 99.08% <99.28%> (+<0.01%) ⬆️
Py-3.10.11 99.06% <99.28%> (+<0.01%) ⬆️
Py-3.10.15 99.30% <99.28%> (+<0.01%) ⬆️
Py-3.11.10 99.30% <99.28%> (+<0.01%) ⬆️
Py-3.11.9 99.06% <99.28%> (+<0.01%) ⬆️
Py-3.12.7 99.30% <99.28%> (+<0.01%) ⬆️
Py-3.13.0 99.30% <99.28%> (+<0.01%) ⬆️
Py-3.9.13 99.02% <99.28%> (+<0.01%) ⬆️
Py-3.9.20 99.25% <99.28%> (+<0.01%) ⬆️
Py-pypy7.3.16 99.30% <99.28%> (+<0.01%) ⬆️
Py-pypy7.3.17 99.33% <99.28%> (+<0.01%) ⬆️
VM-macos-latest 99.08% <99.28%> (+<0.01%) ⬆️
VM-ubuntu-latest 99.34% <99.28%> (+<0.01%) ⬆️
VM-windows-latest 99.40% <99.28%> (+<0.01%) ⬆️
pytest 99.34% <99.28%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review October 21, 2024 05:20
@bdraco bdraco merged commit 55967c2 into master Oct 21, 2024
42 of 46 checks passed
@bdraco bdraco deleted the parse_module branch October 21, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant